Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels of components hidden (direct or by logic) show up in summary #1451

Closed
13 tasks done
Bartvaderkin opened this issue Mar 18, 2022 · 2 comments
Closed
13 tasks done

Labels of components hidden (direct or by logic) show up in summary #1451

Bartvaderkin opened this issue Mar 18, 2022 · 2 comments
Assignees
@sergei-maertens
Labels
owner: den-haag
Milestone
Release 1.1.0

Comments

@Bartvaderkin
Copy link
Contributor

Bartvaderkin commented Mar 18, 2022 •
edited by sergei-maertens

Taiga DH 10

The ticket specifically mentions the case where parts of the form are conditional but the labels of hidden components still show up and potentially confuse the end-user into assuming they missed something.

Tasks

Prototyping was done in #1549

  • Set up renderer with different modes
  • Emit (child) nodes that all know how to render themselves
  • Implement confirmation email (HTML, text) using the renderer
  • Implement a CLI renderer for debugging purposes
  • Implement a confirmation PDF renderer
  • Implement the registration email using the renderer
  • Implement exports using the renderer
  • Add the FormIO options in form builder for showIn<RenderMode>
  • Write management command/diagnostic to detect usage of deprecated template tags/functionalities
  • Developer documentation
  • Add render management command (default to RenderModes.cli, optionally specify a render mode)
  • Implement showInSummary in the SDK
  • Add total cost (if relevant) to confirmation PDF
@Bartvaderkin Bartvaderkin changed the title Labels of components hidden (direct of by logic) show up in summary Labels of components hidden (direct or by logic) show up in summary Mar 18, 2022
@joeribekker
Copy link
Contributor

Discussed, see results below

IMG_20220324_120510

@Bartvaderkin Bartvaderkin self-assigned this Mar 24, 2022
Bartvaderkin added a commit that referenced this issue Mar 28, 2022
@Bartvaderkin
[#1451] Submission rendering WIP
89ba323
Bartvaderkin added a commit that referenced this issue Mar 31, 2022
@Bartvaderkin
[#1451] Submission rendering WIP
5fdc024
Bartvaderkin added a commit that referenced this issue Apr 11, 2022
@Bartvaderkin
[#1451] Submission rendering WIP
3db0e1f
Bartvaderkin added a commit that referenced this issue Apr 11, 2022
@Bartvaderkin
[#1451] Submission rendering WIP
7aa11ba
@sergei-maertens sergei-maertens self-assigned this Apr 25, 2022
This was referenced Apr 28, 2022
Closed
Closed
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
✨ [#1451] -- set up plumbing for submission rendering
c6d4fca 
This sets up the base renderer class and Node (sub)classes to render
various data aspects of a form submission. Calling code is responsible
for processing the produced nodes while rendering.
@sergei-maertens sergei-maertens mentioned this issue Apr 29, 2022
Merged
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
📝 [#1451] -- add developer documentation for renderer
385d573
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
✨ [#1451] -- incorporate form logic in the submission renderer
0e18ad2
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
⚡ [#1451] -- ensure that rendering a submission does not lead to an e…
5ceba4c 
…xplosion of queries
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
🏗️ [#1451] -- Lay out the architecture for Formio component node rend…
c56d06a 
…ering

This puts the configuration and base classes in place to construct
render nodes capable of undertanding Formio components. Where possible,
it defers to existing functionality in openforms.formio package.
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
✅ [#1451] -- add tests for ComponentNode generic behaviour
1c275dd
@sergei-maertens sergei-maertens mentioned this issue Apr 29, 2022
Merged
sergei-maertens added a commit that referenced this issue Apr 29, 2022
@sergei-maertens
✅ [#1451] -- add tests for ComponentNode generic behaviour
fda69f2
@sergei-maertens sergei-maertens added this to the Release 1.1.0 milestone Apr 29, 2022
sergei-maertens added a commit that referenced this issue May 2, 2022
@sergei-maertens
✅ [#1451] -- add tests for fieldset/columns component rendering behav…
1e5f84a 
…iour

Fieldsets should only be visible if not explicitly hidden AND if they
have visible children.
sergei-maertens added a commit that referenced this issue May 2, 2022
@sergei-maertens
✅ [#1451] -- add tests for expected WYSIWYG output
f4c1e18
sergei-maertens added a commit that referenced this issue May 2, 2022
@sergei-maertens
✨ [#1451] -- implement render nodes for Formio component types
92bb23f
@sergei-maertens sergei-maertens mentioned this issue May 2, 2022
Merged
sergei-maertens added a commit that referenced this issue May 2, 2022
@sergei-maertens
✨ [#1451] -- columns never output their label
e24d346
sergei-maertens added a commit that referenced this issue May 2, 2022
@sergei-maertens
📝 [#1451] -- document FormIO render node classes/interface
7f4cc8a
sergei-maertens added a commit that referenced this issue May 4, 2022
@sergei-maertens
⚰️ [#1451] -- Remove Submission.get_printable_data
2c5b5ed 
Good riddance.
sergei-maertens added a commit that referenced this issue May 4, 2022
@sergei-maertens
⚰️ [#1451] -- Remove Submission.get_printable_data
f250229 
Good riddance.
sergei-maertens added a commit that referenced this issue May 6, 2022
@sergei-maertens
♻️ [#1451] -- implement registration e-mail using the renderer
1c9384c
sergei-maertens added a commit that referenced this issue May 6, 2022
@sergei-maertens
⚰️ [#1451] -- remove SubmittedDataWrapper
8970765 
This functionality is now completely replaced with the submission renderer
and format_value functionality.
sergei-maertens added a commit that referenced this issue May 6, 2022
@sergei-maertens
♻️ [#1451] -- implement registration e-mail using the renderer
4d2e07b
sergei-maertens added a commit that referenced this issue May 6, 2022
@sergei-maertens
⚰️ [#1451] -- remove SubmittedDataWrapper
66039e0 
This functionality is now completely replaced with the submission renderer
and format_value functionality.
sergei-maertens added a commit that referenced this issue May 6, 2022
@sergei-maertens
⚰️ [#1451] -- Remove Submission.get_printable_data
d7b63bd 
Good riddance.
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
✅ [#1451] -- add test for expected export data format
6440881
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
♻️ [#1451] -- rework submission exports with renderer
cfd6c75 
Note that this effectively changes the output data including headers
that may not have been emitted before because they were hidden.
@sergei-maertens sergei-maertens mentioned this issue May 9, 2022
Merged
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
✅ [#1451] -- add test for expected export data format
9def0ad
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
♻️ [#1451] -- rework submission exports with renderer
fd0af05 
Note that this effectively changes the output data including headers
that may not have been emitted before because they were hidden.
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
💚 [#1451] -- fix bug in export test
393138d 
Form definition key did not match the submission data key
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
✨ [#1451] -- add showInPDF and showInSummary to form builder
055274d
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
🗃️ [#1451] -- add data migration to add the new display/presentation …
941584a 
…options with default values
@sergei-maertens sergei-maertens mentioned this issue May 9, 2022
Merged
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
✨ [#1451] -- add showInPDF and showInSummary to form builder
9c941f8
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
🗃️ [#1451] -- add data migration to add the new display/presentation …
db5595e 
…options with default values
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
🔨 [#1451] -- Add management command to check for template tag usage
ffbbe30
@sergei-maertens sergei-maertens mentioned this issue May 9, 2022
Closed
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
🔥 [#1451] -- delete display_value template tag
4a45bab 
This has been superceded by the renderer interface
This was referenced May 9, 2022
Merged
Merged
sergei-maertens added a commit that referenced this issue May 9, 2022
@sergei-maertens
👌 [#1451] -- PR feedback
2350e2d
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue May 9, 2022
@sergei-maertens
✨ [open-formulieren/open-forms#1451] -- don't display fieldset in sum…
7876715 
…mary if header is hidden
@sergei-maertens
Copy link
Member

Done 🎉

sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue May 10, 2022
@sergei-maertens
🐛 [open-formulieren/open-forms#1451] -- do not show labels of wysiwyg…
e6b4675 
… content
@sergei-maertens sergei-maertens mentioned this issue Nov 9, 2022
Closed
@sergei-maertens sergei-maertens mentioned this issue Mar 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
owner: den-haag
Projects
None yet
Milestone
Release 1.1.0
Development

Successfully merging a pull request may close this issue.

Feature/1451 submission rendering api open-formulieren/open-forms
3 participants
@joeribekker @sergei-maertens @Bartvaderkin