Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WYSIWYG content with linebreaks is not displayed properly in summary page #2244

Closed
sergei-maertens opened this issue Oct 25, 2022 · 2 comments · Fixed by #2328
Closed

WYSIWYG content with linebreaks is not displayed properly in summary page #2244

sergei-maertens opened this issue Oct 25, 2022 · 2 comments · Fixed by #2328
Assignees
Labels
bug Something isn't working
Milestone

Comments

@sergei-maertens
Copy link
Member

Product versie / Product version

2.0.0

Omschrijf het probleem / Describe the bug

When you have a WYSIWYG content element as part of a form step with multiple lines/whitespace/linebreaks, the summary page does not display this whitespace but instead appends everything together.

It looks like some newlines are not properly converted to <br> tags, or the WYWIWYG content is stripped from HTML tags.

Stappen om te reproduceren / Steps to reproduce

  1. Define form with content field containing blank lines
  2. Fill out form
  3. Continue to summary page
  4. Observe the missing whitespace

Verwacht gedrag / Expected behavior

Whitespace from the WYWIWYG field is displayed in a consistent way in the form designer, step and summary.

Screen resolution

bigger

Device

Desktop

OS

Linux

Browser

Chrome, Anders / Other

@sergei-maertens sergei-maertens added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Oct 25, 2022
@sergei-maertens sergei-maertens added this to the Release 2.0.1 milestone Oct 25, 2022
@Bartvaderkin Bartvaderkin self-assigned this Nov 3, 2022
@Bartvaderkin
Copy link
Contributor

The summary page content is rendered as text:

renderer = Renderer(submission=self, mode=RenderModes.pdf, as_html=False)

Bartvaderkin pushed a commit that referenced this issue Nov 8, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 8, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 8, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 8, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 8, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 9, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 9, 2022
…nSummary` showing up in server rendered summary
@Bartvaderkin
Copy link
Contributor

Bartvaderkin commented Nov 9, 2022

Note for posterity: after investigation this was not an issue of rendering the non-HTML version, but having the 'content' component show up in the summary at all.

See #1451 for the original discussion and decisions

@Bartvaderkin Bartvaderkin removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Nov 9, 2022
Bartvaderkin pushed a commit that referenced this issue Nov 9, 2022
…nSummary` showing up in server rendered summary
sergei-maertens added a commit that referenced this issue Nov 9, 2022
…mmary

[#2244] Fixed 'content' component and components not marked as `showInSummary` showing up in server rendered summary
sergei-maertens pushed a commit that referenced this issue Nov 9, 2022
…nSummary` showing up in server rendered summary
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment