Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date component - no error for min/max date input. #3443

Closed
LaurensBurger opened this issue Sep 1, 2023 · 2 comments · Fixed by #3479 or open-formulieren/open-forms-sdk#548
Closed

Date component - no error for min/max date input. #3443

LaurensBurger opened this issue Sep 1, 2023 · 2 comments · Fixed by #3479 or open-formulieren/open-forms-sdk#548
Assignees
@SilviaAmAm
Labels
bug Something isn't working owner: den-haag
Milestone
Release 2.4.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Sep 1, 2023 •
edited

Product versie / Product version

2.3.0

Omschrijf het probleem / Describe the bug

DH: 577
Date components with validation for minimum and maximum dates do not inform the user about this requirement.
It is clear when clicking the component, because out of range dates will not be available, but if you type in a date that is outside the available range the component will clear itself without informing the user why.
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Sep 1, 2023
@joeribekker
Copy link
Contributor

Refinement: Similar to the time-component issue.

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Sep 4, 2023
@SilviaAmAm
Copy link
Contributor

This is a flatpickr issue: flatpickr/flatpickr#2698

SilviaAmAm added a commit that referenced this issue Sep 11, 2023
@SilviaAmAm
🩹 [#3443] Prevent flatpickr from clearing the value
6372068
SilviaAmAm added a commit that referenced this issue Sep 11, 2023
@SilviaAmAm
✨ [#3443] Add custom errors for date component
ab5ceb8
@SilviaAmAm SilviaAmAm mentioned this issue Sep 11, 2023
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 11, 2023
@SilviaAmAm
🩹 [open-formulieren/open-forms#3443] New validator to catch the case …
5c2bc52 
…where date is entered manually
@SilviaAmAm SilviaAmAm mentioned this issue Sep 11, 2023
Merged
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
🩹 [#3443] Prevent flatpickr from clearing the value
0550624
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
✨ [#3443] Add custom errors for date component
0dd2f7c
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
✨ [#3443] Add migration to add new settings
82264e1
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
✅ [#3443] Test migration adding new settings
d16d978
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
✨ [#3443] Add migration to add new settings
691b545
SilviaAmAm added a commit that referenced this issue Sep 13, 2023
@SilviaAmAm
✅ [#3443] Test migration adding new settings
0015c24
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 13, 2023
@SilviaAmAm
📝 [open-formulieren/open-forms#3443] Attempt at writing a story for t…
01cf715 
…his...

The jest test didnt go anywhere (the method that creates a form with a date component returns a promise that never resolves).
In storybook you can interact manually with a component with a minDate and see that it works. It's something.
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
🩹 [#3443] Prevent flatpickr from clearing the value
c412c3d
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✨ [#3443] Add custom errors for date component
bcd23a5
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✨ [#3443] Add migration to add new settings
a5db3cc
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✅ [#3443] Test migration adding new settings
d21a0c1
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
👌 [#3443] PR Feedback
3fdf5f2
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
🩹 [#3443] Prevent flatpickr from clearing the value
69e5ea1
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✨ [#3443] Add custom errors for date component
14e8c2d
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✨ [#3443] Add migration to add new settings
f2f523d
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
✅ [#3443] Test migration adding new settings
b5cf045
SilviaAmAm added a commit that referenced this issue Sep 20, 2023
@SilviaAmAm
👌 [#3443] PR Feedback
563db37
sergei-maertens added a commit that referenced this issue Sep 20, 2023
@sergei-maertens
Merge pull request #3479 from open-formulieren/fix/3443-date-validation
598083b 
[#3443] Date validation
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 20, 2023
@SilviaAmAm
👌 [open-formulieren/open-forms#3443] PR Feedback
3e982eb
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 20, 2023
@SilviaAmAm
👌 [open-formulieren/open-forms#3443] PR Feedback
67b98f1
@SilviaAmAm SilviaAmAm mentioned this issue Sep 20, 2023
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Sep 20, 2023
@SilviaAmAm
👌 [open-formulieren/open-forms#3443] PR Feedback
d8c0f34
@sergei-maertens sergei-maertens added this to the Release 2.4.0 milestone Sep 20, 2023
@SilviaAmAm SilviaAmAm mentioned this issue Jan 16, 2024
Closed
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
bdd63bb 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✨ [#3577] Add option to allow invalid datetimes to be entered with th…
2221bd8 
…e keyboard

same fix as for issue #3443
@SilviaAmAm SilviaAmAm mentioned this issue Jan 18, 2024
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
9736532 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✨ [#3755] Add option to allow invalid datetimes to be entered with th…
d620aa6 
…e keyboard

same fix as for issue #3443
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 19, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
99d9842 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit that referenced this issue Jan 23, 2024
@SilviaAmAm
✨ [#3755] Add option to allow invalid datetimes to be entered with th…
1d9d0d0 
…e keyboard

same fix as for issue #3443
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working owner: den-haag
Projects
Development
Archived in project
Milestone
Release 2.4.0
4 participants
@joeribekker @sergei-maertens @SilviaAmAm @LaurensBurger