Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form builder - Datetime field empties itself when a invalid date is entered #3755

Closed
vaszig opened this issue Jan 10, 2024 · 3 comments · Fixed by open-formulieren/open-forms-sdk#636, #3787, open-formulieren/types#40 or open-formulieren/formio-builder#112
Closed

Form builder - Datetime field empties itself when a invalid date is entered #3755

vaszig opened this issue Jan 10, 2024 · 3 comments · Fixed by open-formulieren/open-forms-sdk#636, #3787, open-formulieren/types#40 or open-formulieren/formio-builder#112
Assignees
@SilviaAmAm
Labels
bug Something isn't working topic: form renderer
Milestone
Release 2.5.0

Comments

@vaszig
Copy link
Contributor

vaszig commented Jan 10, 2024

Occurs when you set a validation, e.g. date/datetime must be in the future and then enter an invalid value. The date field still displays the invalid value and shows the validation error, the datetime field removes the invalid value and displays no validation error.

The behaviour is consistent with the old form builder

Part of #3733
@vaszig vaszig added triage Issue needs to be validated. Remove this label if the issue considered valid. topic: form builder labels Jan 10, 2024
@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Jan 15, 2024
@joeribekker joeribekker added this to the Release 2.5.0 milestone Jan 15, 2024
@SilviaAmAm
Copy link
Contributor

Steps to reproduce:

  • Create a form in the admin with:
    • A date component with validation 'min value' => in the future
    • A datetime component with validation 'min value' => in the future
  • In the SDK, fill in the form.
    • For both components, enter a date/datetime in the past
    • Observe that the date component shows a validation error, while the datetime component empties itself.

The behaviour for the date component was fixed in this issue: #3443

SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
bdd63bb 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3755] Test min/max datetime validation
ca98e41
@SilviaAmAm SilviaAmAm mentioned this issue Jan 18, 2024
Merged
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
9736532 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 18, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3755] Test min/max datetime validation
8a6bf59
@SilviaAmAm SilviaAmAm mentioned this issue Jan 18, 2024
Merged
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✨ [#3755] Add option to allow invalid datetimes to be entered with th…
d620aa6 
…e keyboard

same fix as for issue #3443
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✨ [#3755] Add error message for invalid datetimes
fb6d850
SilviaAmAm added a commit that referenced this issue Jan 18, 2024
@SilviaAmAm
✅ [#3755] Test migrations
a6c00a4
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 19, 2024
@SilviaAmAm
🐛 [open-formulieren/open-forms#3755] Validate min/max datetime
99d9842 
If the datetime is entered with the keyboard instead of the widget, no validation was being performed. This adds the validation in the same way as for the date component (see open-formulieren/open-forms#3443)
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 19, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3755] Test min/max datetime validation
25589d3
SilviaAmAm added a commit to open-formulieren/types that referenced this issue Jan 22, 2024
@SilviaAmAm
✨ Add the types for the Flatpickr custom options for the widget
5b550cc 
Related to open-formulieren/open-forms#3755 where the widget needs to have a configuration option set so that invalid values are not automatically removed from the widget
@SilviaAmAm SilviaAmAm mentioned this issue Jan 22, 2024
Merged
SilviaAmAm added a commit to open-formulieren/types that referenced this issue Jan 22, 2024
@SilviaAmAm
✨ Add the types for the Flatpickr custom options for the widget
f86b6e5 
Related to open-formulieren/open-forms#3755 where the widget needs to have a configuration option set so that invalid values are not automatically removed from the widget
SilviaAmAm added a commit to open-formulieren/open-forms-sdk that referenced this issue Jan 22, 2024
@SilviaAmAm
👌 [open-formulieren/open-forms#3755] PR Feedback
eb4def7
SilviaAmAm added a commit to open-formulieren/types that referenced this issue Jan 23, 2024
@SilviaAmAm
✅ [open-formulieren/open-forms#3755] Test new date/datetime types
c4bffe2
@SilviaAmAm
Copy link
Contributor

Work in the form builder still needs to happen

@SilviaAmAm SilviaAmAm reopened this Jan 23, 2024
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Jan 23, 2024
@SilviaAmAm
⬆️ [open-formulieren/open-forms#3755] Upgrade types
6978179
SilviaAmAm added a commit to open-formulieren/formio-builder that referenced this issue Jan 23, 2024
@SilviaAmAm
✨ open-formulieren/open-forms#3755] Add custom flatpickr settings to …
0c08adb 
…date and datetime
@SilviaAmAm SilviaAmAm mentioned this issue Jan 23, 2024
Merged
@SilviaAmAm
Copy link
Contributor

Upgrading form builder in backend needs to be done

@SilviaAmAm SilviaAmAm reopened this Jan 23, 2024
SilviaAmAm added a commit that referenced this issue Jan 23, 2024
@SilviaAmAm
✨ [#3755] Add option to allow invalid datetimes to be entered with th…
1d9d0d0 
…e keyboard

same fix as for issue #3443
SilviaAmAm added a commit that referenced this issue Jan 23, 2024
@SilviaAmAm
✨ [#3755] Add error message for invalid datetimes
d07f52c
SilviaAmAm added a commit that referenced this issue Jan 23, 2024
@SilviaAmAm
✅ [#3755] Test migrations
14a6435
sergei-maertens added a commit that referenced this issue Jan 24, 2024
@sergei-maertens
Merge pull request #3787 from open-formulieren/fix/3577-datetime-vali…
507b3c6 
…dation

[#3755] Fix datetime validation
@sergei-maertens sergei-maertens mentioned this issue Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SilviaAmAm SilviaAmAm

Labels
bug Something isn't working topic: form renderer
Projects
Development
Archived in project
Milestone
Release 2.5.0
4 participants
@joeribekker @sergei-maertens @SilviaAmAm @vaszig