Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default timeout is always used for SOAP services #4146

Closed
LaurensBurger opened this issue Apr 10, 2024 · 1 comment · Fixed by #4218
Closed

Default timeout is always used for SOAP services #4146

LaurensBurger opened this issue Apr 10, 2024 · 1 comment · Fixed by #4218
Assignees
@Viicos
Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: maykin
Milestone
Release 2.7.0

Comments

@LaurensBurger
Copy link
Collaborator

LaurensBurger commented Apr 10, 2024 •
edited by Viicos

Product versie / Product version

2.6.2

Omschrijf het probleem / Describe the bug

When setting a custom timeout for a soapservice this is not reflected in the real request, timeout will still occur after 10s and this is also showing in the logs:
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='httpstat.us', port=443): Read timed out. (read timeout=10.0)
image

This seems to only affect the SOAP services, as other services use the timeout from the configuration:
requests.exceptions.ReadTimeout: HTTPSConnectionPool(host='httpstat.us', port=443): Read timed out. (read timeout=11)
image
@LaurensBurger LaurensBurger added bug Something isn't working triage Issue needs to be validated. Remove this label if the issue considered valid. labels Apr 10, 2024
@Viicos
Copy link
Contributor

Viicos commented Apr 10, 2024 •
edited

Support for a custom timeout was added in 287e0a3, however the Stuf ZDS registration makes use of a different client where this timeout config value doesn't seem to be used

@joeribekker joeribekker removed the triage Issue needs to be validated. Remove this label if the issue considered valid. label Apr 15, 2024
@joeribekker joeribekker added this to the Release 2.7.0 milestone Apr 15, 2024
@joeribekker joeribekker added needs-backport Fix must be backported to stable release branch owner: maykin labels Apr 15, 2024
@joeribekker joeribekker assigned Viicos and unassigned vaszig Apr 23, 2024
Viicos added a commit that referenced this issue Apr 23, 2024
@Viicos
[#4146] Apply soap timeout for Stuf-ZDS client
5e6021b 
Unforutately timeouts can't be set at the session level,
resulting in this ugly hack
@Viicos Viicos mentioned this issue Apr 23, 2024
Merged
Viicos added a commit that referenced this issue Apr 25, 2024
@Viicos
[#4146] Apply soap timeout for Stuf-ZDS client
0095e71
Viicos added a commit that referenced this issue Apr 25, 2024
@Viicos
[#4146] Apply soap timeout for Stuf-ZDS client
9a48f0f
Viicos added a commit that referenced this issue Apr 26, 2024
@Viicos
[#4146] Apply soap timeout for Stuf-ZDS client
6129602
sergei-maertens added a commit that referenced this issue Apr 26, 2024
@sergei-maertens
Merge pull request #4218 from open-formulieren/issue/4146-timeout
2fe3233 
[#4146] Apply soap timeout for Stuf-ZDS client
sergei-maertens pushed a commit that referenced this issue Apr 26, 2024
@Viicos @sergei-maertens
[#4146] Apply soap timeout for Stuf-ZDS client
c79d5f9 
Backport-of: #4218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Viicos Viicos

Labels
bug Something isn't working needs-backport Fix must be backported to stable release branch owner: maykin
Projects
Development
Archived in project
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

[#4146] Apply soap timeout for Stuf-ZDS client open-formulieren/open-forms
4 participants
@joeribekker @vaszig @Viicos @LaurensBurger