[#4146] Apply soap timeout for Stuf-ZDS client #4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4218 +/- ##
=======================================
Coverage 96.15% 96.15%
=======================================
Files 732 732
Lines 23391 23397 +6
Branches 2735 2731 -4
=======================================
+ Hits 22492 22498 +6
Misses 637 637
Partials 262 262 ☔ View full report in Codecov by Sentry. |
vaszig
reviewed
Apr 24, 2024
There was a problem hiding this comment.
I am not sure about this fix (if this is the only solution), maybe we should wait for @sergei-maertens 's opinion as well.
sergei-maertens
requested changes
Apr 25, 2024
Viicos
force-pushed
the
issue/4146-timeout
branch
2 times, most recently
from
0095e71
to
9a48f0f
Compare
Viicos
force-pushed
the
issue/4146-timeout
branch
from
9a48f0f
to
6129602
Compare
sergei-maertens
approved these changes
Apr 26, 2024
|
Backport: c79d5f9 (to 2.6.x only, older versions don't have this feature) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4146