Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration refactor #4318

Closed
wants to merge 6 commits into from
Closed

Configuration refactor #4318

wants to merge 6 commits into from

Conversation

Viicos
Copy link
Contributor

@Viicos Viicos commented May 22, 2024

Partly closes #3154

Changes

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 35.54502% with 136 lines in your changes are missing coverage. Please review.

Project coverage is 95.73%. Comparing base (72fabfd) to head (0aa0423).
Report is 16 commits behind head on master.

Current head 0aa0423 differs from pull request most recent head f464f5b

Please upload reports for the commit f464f5b to get more accurate results.

Files Patch % Lines
...ms/submissions/models/submission_value_variable.py 27.35% 85 Missing ⚠️
src/openforms/formio/datastructures.py 41.37% 34 Missing ⚠️
src/openforms/formio/components/vanilla.py 53.33% 7 Missing ⚠️
src/openforms/formio/registry.py 42.85% 4 Missing ⚠️
src/openforms/forms/models/form.py 50.00% 4 Missing ⚠️
src/openforms/forms/models/form_definition.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4318      +/-   ##
==========================================
- Coverage   96.25%   95.73%   -0.52%     
==========================================
  Files         731      731              
  Lines       23718    23936     +218     
  Branches     2795     2838      +43     
==========================================
+ Hits        22829    22915      +86     
- Misses        619      752     +133     
+ Partials      270      269       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rethink SubmissionState and SubmissionValueVariablesState
2 participants