New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move top level power to maintainers #123
Merged
todaywasawesome
merged 4 commits into
open-gitops:main
from
scottrigby:move-top-level-power-to-maintainers
Oct 7, 2022
Merged
Move top level power to maintainers #123
todaywasawesome
merged 4 commits into
open-gitops:main
from
scottrigby:move-top-level-power-to-maintainers
Oct 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intainers Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Scott Rigby <scott@r6by.com>
Also define simple and supermajority voting (more than half and 2/3 of active maintainers), to clarify this clause. Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Scott Rigby <scott@r6by.com>
…ive staus Co-authored-by: Dan Garfield <dan@codefresh.io> Signed-off-by: Scott Rigby <scott@r6by.com>
scottrigby
requested review from
murillodigital,
chris-short,
williamcaban,
todaywasawesome,
christianh814,
niklasmtj,
roberthstrand and
JaimeMagiera
October 3, 2022 04:22
christianh814
approved these changes
Oct 3, 2022
roberthstrand
approved these changes
Oct 3, 2022
niklasmtj
approved these changes
Oct 3, 2022
JaimeMagiera
approved these changes
Oct 5, 2022
williamcaban
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
todaywasawesome
approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfectly done. Great job @scottrigby !
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed at multiple meetings.
While I updated the final wording, @todaywasawesome discussed at length and agreed on the important details. Added Dan to Co-authored-by commit trailer for this reason.
Since this is a major governance change, I assigned all current maintainers (including maintainers who are chairs) as reviewers on this PR.