Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish subtitles (WIP) #1709

Closed
wants to merge 1 commit into from
Closed

Spanish subtitles (WIP) #1709

wants to merge 1 commit into from

Conversation

jml95
Copy link

@jml95 jml95 commented Jul 27, 2022

All the subtitles that are currently availiable in english have been included in the spanish version. Could this be merged in future releases?

-intro
-sidekick
-oracle
-training
-village1
-beach
-jungle
-misty
-firecanyon
-village2
-swamp
-rolling
-sunken
-ogre
-village3
-snowy
-spidercave
-lavatube
-citadel
-finalboss

All the subtitles that are currently availiable have been included in the spanish version. Could this be merged in future releases?

-intro
-sidekick
-oracle
-training
-village1
-beach
-jungle
-misty
-firecanyon
-village2
-swamp
-rolling
-sunken
-ogre
-village3
-snowy
-spidercave
-lavatube
-citadel
-finalboss
@ManDude
Copy link
Member

ManDude commented Jul 27, 2022

Follow the same procedure as in #1502

  • Add the language to the progress menu so users can select it.
  • Add the language to the debug menu (optional).
  • Use the built-in subtitle debugger (L3+Start) to check if every line fits within 2 on-screen lines at 4x3 aspect ratio. (Use "Check all lines" then look at the console.)
  • Check if any hints or movies are missing.

@Hat-Kid
Copy link
Member

Hat-Kid commented Jul 27, 2022

Since #1704 is not merged yet, I went ahead and ran these subtitles through the debugger, these are all the bad lines that need to be split up.

Spanish is already in the subtitle language option in the progress menu and in the debug menu, so you don't need to add it there.

@ManDude
Copy link
Member

ManDude commented Jul 27, 2022

Oh, you're right - I added it lol. Yeah, do the other stuff I guess.

@GKnight95
Copy link

GKnight95 commented Aug 7, 2022

Hey everyone, is there any chance I could help you with the translation? First time using GitHub so not sure to post this comment here but please, let me know! Spanish is my native language btw, thank you!
I'm on the discord server name's YungOmen#1743

@OpenGOALBot
Copy link
Collaborator

Can one of the admins verify this patch?

@xTVaser xTVaser added the jak1 label Oct 11, 2022
@xsm2
Copy link
Contributor

xsm2 commented Oct 17, 2022

Maybe I'm wrong, but I think this commit was already fixed and merged in this PR: #1828 (look at the last commit 07b8088)

If I'm not wrong, the only thing left for Spanish to be complete would be the game_text (the addittional texts that were added for the port's new menus, like the graphic settings) which are still not translated, but I don't think this PR should stay open as it doesn't include them and it has been nearly three months since the last update.

@ManDude ManDude closed this Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants