d/jak2: finish find-nearest | trajectory | editable-h and most of editable and editable-player
#1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
water111
reviewed
Sep 7, 2022
| (let ((v0-3 (cons gp-1 (-> (the-as editable-plane (+ (* s4-0 4) (the-as int gp-1))) vertex 0 owner))) | ||
| (v1-10 (l.wu (+ (* s4-0 4) (the-as int gp-1) 28))) | ||
| ) | ||
| (s.w! (+ v1-10 16) v0-3) |
There was a problem hiding this comment.
FYI these s.w!s and l.wu's compile now, but we should eventually fix these (don't worry about it here, there's still other todos for this file so it can wait)
| (else | ||
| (let ((s1-0 (new 'stack-no-clear 'sphere)) | ||
| (s2-1 ((method-of-type array new) | ||
| (the-as symbol (new 'stack-no-clear 'array 'collide-shape 32)) |
There was a problem hiding this comment.
I remember this working better in jak 1 but I could be wrong... I'll check more later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also made a first-pass of their SQL schema in preparation for getting that working.