Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: Create a JSON subtitle format for translating via Crowdin #2644

Merged
merged 18 commits into from May 19, 2023

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented May 13, 2023

This is pretty close, main thing i have to do is update the subtitle editor.
Subtitle editor mostly works / doesn't crash at least -- but I'll follow up later to clean up the UI. Doesn't feel like a huge priority because the only language that would use it at this point would be japanese.

The plan is to allow translating subtitles via Crowdin for only the languages that don't have an audio accompaniment. Which is fine, because in later games the subtitles for those languages are done for us and Jak 1 is already well translated in this regard (except for japanese). This limitation is because it's just too hard to support distributed translation when different timings / line amounts are involved.

Typically subtitles are done with an SRT file, which is very similar in terms of features as ours -- you have a timestamp and text to display at that timestamp. But this breaks down if different languages change the timings, or split/merge captions. This would never happen in a traditional subtitle setting because you'd be subtitling the same audio, but the game has multiple sets of audio unfortunately.


This new format does a few key things:

  • splits up the translatable text from the timings into separate files
  • centralize speaker translations, so it doesn't have to be done for every single line -- the speaker does not change across languages just the naming (maybe)
  • allows for base timings / base text files to reduce duplication (ie. all languages without audio currently use the english timings, english-uk basically uses the english subtitles)
  • i fixed some inconsistencies in the current translations, and found some ones that were missed (ie. english was missing a hint, etc)
  • added migration code that can be enabled to convert from the old format to the new one if someone requires it -- since this format is a bit more labor-intensitive to do so by hand.

@xTVaser xTVaser marked this pull request as ready for review May 17, 2023 03:01
@xTVaser xTVaser added this to the May 2023 milestone May 17, 2023
@xTVaser xTVaser merged commit 288c093 into open-goal:master May 19, 2023
7 of 8 checks passed
@xTVaser xTVaser deleted the v/subtitle-format branch May 19, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant