Python API: disable autocreate feature on demand #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 4.1.x #1462 +/- ##
==========================================
- Coverage 77.46% 77.18% -0.28%
==========================================
Files 309 309
Lines 58142 58167 +25
Branches 6823 6823
==========================================
- Hits 45040 44898 -142
+ Misses 12955 12910 -45
- Partials 147 359 +212
Continue to review full report at Codecov.
|
AymericDu
approved these changes
May 7, 2018
oio/api/object_storage.py
Outdated
| @@ -324,7 +324,7 @@ class ObjectStorageApi(object): | |||
| - `write_timeout`: `float` | |||
| """ | |||
| TIMEOUT_KEYS = ('connection_timeout', 'read_timeout', 'write_timeout') | |||
| EXTRA_KEYWORDS = ('chunk_checksum_algo', ) | |||
| EXTRA_KEYWORDS = ('chunk_checksum_algo', 'autocreate', ) | |||
There was a problem hiding this comment.
I think the last comma is useless.
oio/api/object_storage.py
Outdated
| @@ -344,7 +344,10 @@ def __init__(self, namespace, logger=None, **kwargs): | |||
| for all HTTP based APIs (except rawx) | |||
| :type pool_manager: `urllib3.PoolManager` | |||
| :keyword chunk_checksum_algo: algorithm to use for chunk checksums. | |||
| Only 'md5' and `None` are supported at the moment. | |||
| Only 'md5' aend `None` are supported at the moment. | |||
Previously, autocreate was forced to True. Parameter is now exposed on API side and default value is True for backward compatibility.
murlock
force-pushed
the
4.1.x_allow_disabled_autocreate
branch
from
3ee0ff5
to
c05daac
Compare
fvennetier
approved these changes
May 9, 2018
fvennetier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The autocreate feature on API Python was hardcoded
ISSUE TYPE
COMPONENT NAME
Python API
SDS VERSION
ADDITIONAL INFORMATION
Default value of autocreate option is still True to avoid breaking backward compat