Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable deprecated initializations for openssl-1.1.0 #10

Merged
merged 1 commit into from Jan 3, 2017

Conversation

eroen
Copy link

@eroen eroen commented Jan 2, 2017

This fixes several undefined reference errors when linking with
openssl-1.1.0c.

X-Gentoo-Bug: 604454
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=604454

This fixes several undefined reference errors when linking with
openssl-1.1.0c.

X-Gentoo-Bug: 604454
X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=604454
@chris-se
Copy link

chris-se commented Jan 2, 2017

I created the original patch that made open-isns work with OpenSSL 1.1 for Debian, and since current open-isns does still compile against 1.1.0c on Debian systems, I wanted to add a bit of background here: in your case it doesn't build, because your OpenSSL is compiled with either no-deprecated or --api=1.1.0 passed to OpenSSL's configure script, so the compatibility layer is not present anymore. If you configure OpenSSL 1.1 with compatibility enabled (as it is in Debian), build of open-isns will not fail. When creating the original patch, I had assumed that nobody would compile OpenSSL 1.1 without the compatibility layer for quite a while, so I didn't bother to include something like this in the first place, but apparently I was wrong.

However, I don't think one needs to rely on a compatibility layer here with the newest OpenSSL version, especially since open-isns doesn't require any non-standard initialization, so dropping the initialization in newer OpenSSL versions is a good idea (starting with 1.1, OpenSSL doesn't require explicit initialization anymore at all), so I'm in favor of applying this patch.

Acked-By: Christian Seiler <christian@iwakd.de>

@prometheanfire
Copy link

bug found in the package that JUST came out 👿

@gonzoleeman
Copy link
Collaborator

Looks good to me, and also compiles on older openssl on SUSE.

@gonzoleeman gonzoleeman merged commit 8a5d881 into open-iscsi:master Jan 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants