Crossmnt is without underscore #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure whether the constants should be renamed as well, I have focused on fixing the parsing error. If the constants are not exported in any way or not in use by other packages, it might be useful to rename them. But I don't know the policy on the constant names. |
|
@dsonck92 Good catch. Changing this constant should be fine too. |
|
I'll add that change to this PR then, but then I will edit it in an IDE just to be sure all identifiers are updated. It's beyond the github file editing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to my own /etc/exports and man exports,
crossmntis without '_' and caused nfs_export_list RPC to erroneously return "method not found" while in fact it didn't findcross_mntwhile decoding the options.