Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent formatting of NOTE alert (#740) #742

Merged
merged 1 commit into from
May 1, 2017

Conversation

Yurockkk
Copy link
Member

Fix inconsistent formatting of NOTE alert (#740)

@Yurockkk
Copy link
Member Author

Yurockkk commented May 1, 2017

here are the rawgit links for the three files I changed in this PR:

nation.md

githubandmarkdown.md

firststeps.md

Copy link
Member

@empeje empeje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve your changes, it is always a good idea to have consistency.

I have checked the following:

  • Check for issue number in pull request title
  • Are there any unneeded files in the pull request?
  • Did they make a branch for their patch?
  • Does the pull request actually fix the issue?
  • Check the pull request on rawgit, does it display without any errors?
  • Is there any merge conflicts?

@Yurockkk for the future, if you have additional information, better to edit your first PR description instead of creating a new comment 😃

@empeje empeje merged commit e7fa7a2 into open-learning-exchange:master May 1, 2017
@Yurockkk
Copy link
Member Author

Yurockkk commented May 1, 2017

@mappuji got it 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants