Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#881] Angular 6 (fixes #881) #1247

Merged
merged 12 commits into from
Jun 7, 2018
Merged

[#881] Angular 6 (fixes #881) #1247

merged 12 commits into from
Jun 7, 2018

Conversation

paulbert
Copy link
Member

@paulbert paulbert commented Jun 6, 2018

Note: Vagrantfile does not successfully update Node to 8.x. Need to run sudo apt upgrade from inside the VM to complete the upgrade.

Includes a lot of automatic changes from Angular and Rxjs upgrade scripts.

#881

@paulbert paulbert changed the title Angular 6 [#881] Angular 6 (fixes #881) Jun 6, 2018
@paulbert
Copy link
Member Author

paulbert commented Jun 6, 2018

@sahilph @dogi @mappuji I had to remove the --arch flag from the ng build command in the crosscompile script. Angular was throwing an error & not running the build command otherwise.

Tested the build and it is still working on a Raspberry Pi, but let me know if we need that flag or something similar for the build command.

@empeje
Copy link
Member

empeje commented Jun 6, 2018

I don't know current updates for ng cli I assume it detects the architecture automatically in version 6. The thing we need to do is testing. Any special reason why previously we need to specify --arch @sahilph ?

@dogi
Copy link
Member

dogi commented Jun 7, 2018

impressive change list

@lmmrssa
Copy link
Member

lmmrssa commented Jun 7, 2018

Delete button on titlebar does not work. It gives undefined as meetup id. Delete on individual row works.
screen shot 2018-06-07 at 16 57 30

Layout of User list is broken. Also Add Team button does not work on each row. All other action including remove team works. Add Team on titlebar also works.
Add Team and Remove Team of individual row does not update.
screen shot 2018-06-07 at 16 58 05

Open profile of another user and edit it. Then profile icon on top header bar takes to profile of edited user. Homepage shows correct profile details.
screen shot 2018-06-07 at 17 04 11
screen shot 2018-06-07 at 17 04 19

@lmmrssa
Copy link
Member

lmmrssa commented Jun 7, 2018

All these issues seems to be on latest release itself so not related to angular except broken layout of users list view.

@lmmrssa lmmrssa merged commit 4c401fc into master Jun 7, 2018
@lmmrssa lmmrssa deleted the angular-6 branch June 11, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants