fix #3077: Fixed validation error in ldap (#3079)

* fix #3077: fixed validation error * removed print * changes returntype to OMetaUserProfile
open-metadata · Mar 3, 2022 · 3f144a7 · 3f144a7
1 parent e4e11a7
commit 3f144a7
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 79 deletions.
diff --git a/ingestion/examples/workflows/ldap_user_to_catalog.json b/ingestion/examples/workflows/ldap_user_to_catalog.json
@@ -8,10 +8,8 @@
     }
   },
   "sink": {
-    "type": "ldap-rest-users",
-    "config": {
-      "api_end_point": "http://localhost:8585/api"
-    }
+    "type": "metadata-rest",
+    "config": {}
   },
   "metadata_server": {
     "type": "metadata-server",

diff --git a/ingestion/src/metadata/ingestion/sink/ldap_rest_users.py b/ingestion/src/metadata/ingestion/sink/ldap_rest_users.py
diff --git a/ingestion/src/metadata/ingestion/source/ldap_users.py b/ingestion/src/metadata/ingestion/source/ldap_users.py
@@ -82,12 +82,12 @@ def create(
         metadata_config = MetadataServerConfig.parse_obj(metadata_config_dict)
         return cls(ctx, config, metadata_config)
 
-    def next_record(self) -> Iterable[CreateUserRequest]:
+    def next_record(self) -> Iterable[OMetaUserProfile]:
         for user in self.users:
             user_metadata = CreateUserRequest(
-                email=user["attributes"]["mail"],
-                displayName=user["attributes"]["cn"],
-                name=user["attributes"]["givenName"],
+                email=user["attributes"]["mail"][0],
+                displayName=user["attributes"]["cn"][0],
+                name=user["attributes"]["givenName"][0],
             )
             self.status.scanned(user_metadata.name)
             yield OMetaUserProfile(user=user_metadata)