Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #3077: Fixed validation error in ldap #3079

Merged
merged 3 commits into from Mar 3, 2022
Merged

fix #3077: Fixed validation error in ldap #3079

merged 3 commits into from Mar 3, 2022

Conversation

ulixius9
Copy link
Member

@ulixius9 ulixius9 commented Mar 2, 2022

Describe your changes :

fix #3077: Fixed validation error in ldap

Type of change :

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

@harshach @ayush-shah @pmbrull

ayush-shah
ayush-shah reviewed Mar 2, 2022
View reviewed changes
ingestion/src/metadata/ingestion/source/ldap_users.py Outdated
@@ -84,10 +84,11 @@ def create(

def next_record(self) -> Iterable[CreateUserRequest]:
for user in self.users:
print(user)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove print from here?

@ayush-shah
Copy link
Member

can you remove the ldap-rest file under sink?

pmbrull
pmbrull approved these changes Mar 2, 2022
View reviewed changes
Copy link
Collaborator

@pmbrull pmbrull left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, a small comment if you have the time. You can merge this in after checking @ayush-shah comments.
Thanks!

ingestion/src/metadata/ingestion/source/ldap_users.py Outdated
@@ -85,9 +85,9 @@ def create(
def next_record(self) -> Iterable[CreateUserRequest]:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small detail, but we could change the signature here to return Iterable[OMetaUserProfile]

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ayush-shah ayush-shah merged commit 3f144a7 into open-metadata:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayush-shah ayush-shah ayush-shah left review comments

@pmbrull pmbrull pmbrull approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LDAP User Ingestion fails
3 participants
@ulixius9 @ayush-shah @pmbrull