Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profiler validation for Composed Metrics #2877

Closed
pmbrull opened this issue Feb 20, 2022 · 0 comments · Fixed by #2926
Closed

Profiler validation for Composed Metrics #2877

pmbrull opened this issue Feb 20, 2022 · 0 comments · Fixed by #2926
Assignees

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Feb 20, 2022

Feature
Based on #2845

Describe the task
Composed Metrics are based on +1 other metrics. E.g., based on the count and null_count of a column, we can obtain the null_ratio.

When building a profiler, we should validate during init that there are all the ingredients ready to compute the desired composed metrics. This means:

  • Adding an abstractmethod in the ComposedMetric class to inform the ingredients
  • Add a validation step when creating a profiler
@pmbrull pmbrull self-assigned this Feb 20, 2022
@pmbrull pmbrull added this to To do in Release 0.9.0 via automation Feb 20, 2022
@pmbrull pmbrull added this to the Milestone 4 - 0.9.0 Release milestone Feb 21, 2022
@pmbrull pmbrull moved this from To do to In progress in Release 0.9.0 Feb 22, 2022
pmbrull added a commit to pmbrull/OpenMetadata that referenced this issue Feb 22, 2022
Release 0.9.0 automation moved this from In progress to Done Feb 24, 2022
pmbrull added a commit that referenced this issue Feb 24, 2022
…2926)

Fix #2878 & #2877 - Implement Metrics and Validate Composed Metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant