Fix #2878 & #2877 - Implement Metrics and Validate Composed Metrics #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ingestion/src/metadata/orm_profiler/metrics/composed/duplicate_count.py # ingestion/src/metadata/orm_profiler/metrics/composed/null_ratio.py # ingestion/src/metadata/orm_profiler/metrics/registry.py # ingestion/src/metadata/orm_profiler/profiles/core.py # ingestion/tests/unit/profiler/test_metrics.py
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
harshach
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
This PR fixes #2877 and #2878
We have implemented the missing core metrics from here and also added a step during the Profiler initialization to validate that all composed metrics have the necessary metrics added to make sure the computation can go through.
This way we do not need to wait until execution time to get no results, but can easily know if something is not properly configured.
Thanks!
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers