Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review implementation of ColumnValuesToMatchRegex #3105

Closed
pmbrull opened this issue Mar 3, 2022 · 1 comment · Fixed by #3149
Closed

Review implementation of ColumnValuesToMatchRegex #3105

pmbrull opened this issue Mar 3, 2022 · 1 comment · Fixed by #3149
Assignees

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Mar 3, 2022

Feature
Based on #1311

Describe the task
Two things to check here:

  • Regex strategy to follow: @harshach are we talking about python-level regex or aiming towards SQL-supported 'LIKE' syntax? I am assuming the second, but just to confirm.
  • We'll need to review how we want to create tests based on metrics with specific parameters requirements that can change from col to col.
@pmbrull pmbrull self-assigned this Mar 3, 2022
@pmbrull pmbrull added this to To do in Release 0.9.0 via automation Mar 3, 2022
@pmbrull pmbrull added this to the Milestone 5 - 0.9.0 Release milestone Mar 3, 2022
@harshach
Copy link
Collaborator

harshach commented Mar 3, 2022

@pmbrull lets use SQL Like and second thing is email regex that we should see if we can pass down to sql instead of doing in python

Release 0.9.0 automation moved this from To do to Done Mar 4, 2022
pmbrull added a commit that referenced this issue Mar 4, 2022
Fix #3105 - ColumnValuesToMatchRegex & other fixes (#3149)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants