Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Quality - Add Test Button #3223

Closed
pmbrull opened this issue Mar 7, 2022 · 4 comments · Fixed by #3272
Closed

Data Quality - Add Test Button #3223

pmbrull opened this issue Mar 7, 2022 · 4 comments · Fixed by #3272
Assignees
@Sachin-chaurasiya
Labels
P0 Highest priority
Projects
Release 0.9.0
Milestone
Milestone 5 - 0.9...

Comments

@pmbrull
Copy link
Collaborator

pmbrull commented Mar 7, 2022 •
edited

Highlight a bit more the Add Test button

image

Should have the same style as the webhook

image

Let's see if we can make it pop a bit more when we have other tests configured

image
@pmbrull
Copy link
Collaborator Author

pmbrull commented Mar 7, 2022

cc @Sachin-chaurasiya @ShaileshParmar11

@pmbrull pmbrull mentioned this issue Mar 7, 2022
Closed
@harshach harshach added the P0 Highest priority label Mar 7, 2022
@harshach harshach added this to the Milestone 5 - 0.9.0 Release milestone Mar 7, 2022
@Sachin-chaurasiya Sachin-chaurasiya added this to To do in Release 0.9.0 via automation Mar 8, 2022
@pmbrull
Copy link
Collaborator Author

pmbrull commented Mar 8, 2022

Hi @Sachin-chaurasiya, great work on all the improvements. The "Add Test" now looks better when we have other tests, but I still would highlight a bit more the button when the tab is empty:
image
I believe we can close this after this change.

Thanks!

@ShaileshParmar11
Copy link
Contributor

Hey this changes will reflect once my PR merge. @pmbrull

@pmbrull
Copy link
Collaborator Author

pmbrull commented Mar 8, 2022

Hey this changes will reflect once my PR merge. @pmbrull

Amazing thanks 🙏

@ShaileshParmar11 ShaileshParmar11 mentioned this issue Mar 8, 2022
Merged
9 tasks
Sachin-chaurasiya pushed a commit that referenced this issue Mar 8, 2022
@ShaileshParmar11
Fix: Data quality bug fixes (#3272)
63c7f2c 
* Fixed: issue #3223, #3228, #3260, #3243,

* addressing comment

* fixed broken test
Release 0.9.0 automation moved this from To do to Done Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sachin-chaurasiya Sachin-chaurasiya

Labels
P0 Highest priority
Projects
No open projects
Release 0.9.0
Done
Milestone
Milestone 5 - 0.9.0 Release
Development

Successfully merging a pull request may close this issue.

Fix: Data quality bug fixes
4 participants
@harshach @pmbrull @Sachin-chaurasiya @ShaileshParmar11