Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Data quality bug fixes #3272

Merged
merged 4 commits into from Mar 8, 2022
Merged

Fix: Data quality bug fixes #3272

merged 4 commits into from Mar 8, 2022

Conversation

ShaileshParmar11
Copy link
Contributor

@ShaileshParmar11 ShaileshParmar11 commented Mar 8, 2022

Describe your changes :

Closes #3223 Data Quality - Add Test Button
Closes #3228 Data Quality - Test on complex types
Closes #3260 Data Quality - columnValuesToBeUnique & columnValuesToBeNotNull JSON UI
Closes #3243 Data Profiler - Add Test against column should have said column selected by default

Type of change :

  • Bug fix
  • Improvement

Frontend Preview (Screenshots) :

Closes #3223 Data Quality - Add Test Button
image
image

Closes #3228 Data Quality - Test on complex types
image

Closes #3260 Data Quality - columnValuesToBeUnique & columnValuesToBeNotNull JSON UI
image
image

Closes #3243 Data Profiler - Add Test against column should have said column selected by default
https://user-images.githubusercontent.com/71748675/157252862-5f33fffc-d121-4824-86b3-e38c5b2fde0e.mov

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Frontend: @shahsank3t, @darth-coder00, @Sachin-chaurasiya

@harshach
Copy link
Collaborator

harshach commented Mar 8, 2022

@ShaileshParmar11 instead of Actions -> rename to "Add Tests"

@Sachin-chaurasiya Sachin-chaurasiya marked this pull request as draft March 8, 2022 15:06
@ShaileshParmar11 ShaileshParmar11 marked this pull request as ready for review March 8, 2022 15:16
@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2022

[catalog] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Sachin-chaurasiya Sachin-chaurasiya merged commit 63c7f2c into open-metadata:main Mar 8, 2022
@ShaileshParmar11 ShaileshParmar11 deleted the data-quality-fix branch March 8, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants