Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: add test for sqla compiler #15275

Merged
merged 7 commits into from
Feb 22, 2024
Merged

MINOR: add test for sqla compiler #15275

merged 7 commits into from
Feb 22, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Feb 20, 2024 •
edited

Describe your changes:

Following #15132, this test enables testing the sql-alchemy compiler behavior for specific dialects. Can be useful when we don't have access to the technology (like IBM-i)

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

@sushi30 sushi30 requested a review from a team as a code owner February 20, 2024 17:54
@sushi30 sushi30 changed the title add test for sqla compiler MINOR: add test for sqla compiler Feb 20, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Feb 20, 2024
@github-actions GitHub Actions
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sushi30 sushi30 merged commit 4967e09 into main Feb 22, 2024
11 checks passed
@sushi30 sushi30 deleted the test-sql-compiler branch February 22, 2024 13:45
TeddyCr added a commit to TeddyCr/OpenMetadata that referenced this pull request Feb 28, 2024
@TeddyCr
Revert "MINOR: add test for sqla compiler (open-metadata#15275)"
387e638 
This reverts commit 4967e09.
TeddyCr added a commit that referenced this pull request Feb 28, 2024
@TeddyCr
1.3.1 reverts (#15386)
7456915 
* Revert "add migration for MongoDB supportsProfiler = true (#15254)"

This reverts commit ec3eb29.

* Revert "MINOR: Mongodb column profile (#15252)"

This reverts commit 50b2709.

* Revert "MINOR: modified nosql factory to not use pymongo (#15316)"

This reverts commit bdf2745.

* Revert "MINOR: add MongoDB sample data (#15237)"

This reverts commit ff2ecc5.

* Revert "MINOR: add test for sqla compiler (#15275)"

This reverts commit 4967e09.

* Revert "Fixes #10013: Implement first stage of NoSQL profiler (#15189)"

This reverts commit 18c22c4.

* chore: added tests back after revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

Assignees
No one assigned
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sushi30 @TeddyCr