Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: modified nosql factory to not use pymongo #15316

Merged
merged 6 commits into from
Feb 23, 2024
Merged

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Feb 22, 2024

Describe your changes:

Fixes:

{
    "code": 400,
    "message": "Athena_metadata_8GOJ9N98 Failed to deploy Ingestion Pipeline due to airflow API returned Internal Server Error and response {\"error\": \"Internal error while deploying due to [No module named 'pymongo'] \"}"
}

I worked on ... because ...

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sushi30 sushi30 requested a review from a team as a code owner February 22, 2024 13:00
@sushi30 sushi30 changed the title modified nosql factory to not use pymongo MINOR: modified nosql factory to not use pymongo Feb 22, 2024
@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Feb 22, 2024
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

TeddyCr
TeddyCr previously approved these changes Feb 22, 2024
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

TeddyCr
TeddyCr previously approved these changes Feb 22, 2024
Copy link

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sushi30 sushi30 requested a review from TeddyCr February 22, 2024 16:33
Copy link

sonarcloud bot commented Feb 23, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
1 New issue

Measures
0 Security Hotspots
88.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ayush-shah ayush-shah merged commit bdf2745 into main Feb 23, 2024
11 checks passed
@ayush-shah ayush-shah deleted the fix-nosql-factory branch February 23, 2024 11:19
TeddyCr added a commit to TeddyCr/OpenMetadata that referenced this pull request Feb 28, 2024
TeddyCr added a commit that referenced this pull request Feb 28, 2024
* Revert "add migration for MongoDB supportsProfiler = true (#15254)"

This reverts commit ec3eb29.

* Revert "MINOR: Mongodb column profile (#15252)"

This reverts commit 50b2709.

* Revert "MINOR: modified nosql factory to not use pymongo (#15316)"

This reverts commit bdf2745.

* Revert "MINOR: add MongoDB sample data (#15237)"

This reverts commit ff2ecc5.

* Revert "MINOR: add test for sqla compiler (#15275)"

This reverts commit 4967e09.

* Revert "Fixes #10013: Implement first stage of NoSQL profiler (#15189)"

This reverts commit 18c22c4.

* chore: added tests back after revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants