Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE : fix teams page breaking issue #17268

Merged
merged 4 commits into from
Aug 2, 2024
Merged

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

  • I worked fixing on the Team page breaking due to % in its name
  • fix the tooltip title for the Group type edit button

Issue :

image
Screen.Recording.2024-08-01.at.7.07.07.PM.mov

Resolved :

Screen.Recording.2024-08-01.at.7.08.23.PM.mov
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

Copy link
Contributor

github-actions bot commented Aug 1, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 65%
64.99% (36825/56663) 41.65% (14607/35071) 43.73% (4473/10228)

Copy link

sonarcloud bot commented Aug 2, 2024

@chirag-madlani chirag-madlani merged commit dd81585 into main Aug 2, 2024
14 of 15 checks passed
@chirag-madlani chirag-madlani deleted the team-page-break-issue branch August 2, 2024 17:16
harshach pushed a commit that referenced this pull request Aug 3, 2024
* fix teams page breaking issue

* minor changes

* unpushed file

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
IceS2 pushed a commit that referenced this pull request Aug 5, 2024
* fix teams page breaking issue

* minor changes

* unpushed file

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e:Settings safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants