Add support for default role #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Schema Change Detected. Needs ingestion-core version bump Please run |
mithmatt
force-pushed
the
role_query_param
branch
2 times, most recently
from
387633b
to
ed8715b
Compare
|
[catalog] Please retry analysis of this Pull-Request directly on SonarCloud. |
mithmatt
force-pushed
the
role_query_param
branch
3 times, most recently
from
cb153e0
to
802f5e4
Compare
mithmatt
force-pushed
the
role_query_param
branch
from
802f5e4
to
b69c1f8
Compare
|
[catalog] Kudos, SonarCloud Quality Gate passed! |
|
All py tests are failing - need to investigate outside of this PR |
12 tasks
mithmatt
force-pushed
the
role_query_param
branch
from
07dd008
to
e7ddebe
Compare
mithmatt
force-pushed
the
role_query_param
branch
from
e7ddebe
to
51ebbef
Compare
mithmatt
commented
Feb 5, 2022
| @@ -0,0 +1,7 @@ | |||
| -- Set default as false for all existing roles, to avoid unintended manipulation of roles during migration. | |||
There was a problem hiding this comment.
Tested this manually with bootstrap migrate-all
|
|
||
| @Override | ||
| public void entitySpecificUpdate() throws IOException { | ||
| recordChange("default", original.getEntity().getDefault(), updated.getEntity().getDefault()); |
There was a problem hiding this comment.
This is a minor version change
mithmatt
commented
Feb 5, 2022
| create = createRequest(test, 2); | ||
| createUserAndCheckRoles(create, Arrays.asList(defaultRoleId)); | ||
|
|
||
| // Given a default role has been set, when a user is created with a non default role, then the default role should |
There was a problem hiding this comment.
"BDD given, when, then" description for different users being created for this test
harshach
approved these changes
Feb 6, 2022
mithmatt
added a commit
to mithmatt/OpenMetadata
that referenced
this pull request
Feb 7, 2022
This reverts commit bfcd97e.
amiorin
pushed a commit
that referenced
this pull request
Feb 7, 2022
mithmatt
added a commit
to mithmatt/OpenMetadata
that referenced
this pull request
Feb 19, 2022
- Add default field to role - Amend GET /roles to query default roles - Assign default role to new users being created
mithmatt
added a commit
that referenced
this pull request
Feb 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
When a new user is created, the default role is assigned to the user automatically by the backend.
Default role can be queried through GET /roles API
There is one more part remaining -- to switch default role from existing one to another.
See #2460 for details
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers
Backend: @sureshms @harshach