Fix #2897 - Profiler CLI #2967
Merged
Fix #2897 - Profiler CLI #2967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # ingestion/src/metadata/orm_profiler/metrics/composed/duplicate_count.py # ingestion/src/metadata/orm_profiler/metrics/composed/null_ratio.py # ingestion/src/metadata/orm_profiler/metrics/registry.py # ingestion/src/metadata/orm_profiler/profiles/core.py # ingestion/tests/unit/profiler/test_metrics.py
|
[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed! |
mithmatt
approved these changes
Feb 24, 2022
| config = FileSinkConfig.parse_obj(config_dict) | ||
| return cls(ctx, config) | ||
|
|
||
| def write_record(self, record: ProfileAndTests) -> None: |
There was a problem hiding this comment.
jinja template could have helped you here :)
There was a problem hiding this comment.
yeah.. not the greatest solution, just needed something quick for the demo 😅
There was a problem hiding this comment.
I'll get this fixed after we apply the new test result classes 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
This PR fixes #2897
We have added the
profilecommand in the CLI, added some fixes from testing the solution against MSSQL and created a FileSink object to play around the solution E2E.Thanks!
Type of change :
Frontend Preview (Screenshots) :
For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.
Checklist:
Reviewers