added skip config for ui build-check #3030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[catalog] Kudos, SonarCloud Quality Gate passed!
|
mithmatt
reviewed
Mar 1, 2022
openmetadata-ui/pom.xml
Outdated
| <!-- optional: the default phase is "generate-resources" --> | ||
| <phase>test</phase> | ||
| <configuration> | ||
| <!-- optional: if not specified, it will run gulp's default task |
There was a problem hiding this comment.
Can we remove these comments?
They seem outdated
For reference on what these parameters are, one can always look at maven documentation
There was a problem hiding this comment.
Addressed in the latest commit.
harshach
approved these changes
Mar 1, 2022
| @@ -83,7 +83,8 @@ | |||
| "lint": "eslint \"./src/**/*.{js,jsx,ts,tsx}\"", | |||
| "lint:fix": "eslint './src/**/*.{js,jsx,ts,tsx}' --fix", | |||
| "pretty": "prettier . --config './.prettierrc' --write", | |||
| "build-check": "yarn run lint && yarn run test", | |||
| "build-check": "yarn run lint", | |||
| "build-test": "yarn run test", | |||
There was a problem hiding this comment.
Is this included in the GitHub CI to detect frontend unit test failures?
There was a problem hiding this comment.
Yes unit tests will run for mvn clean package, and same runs in CI
mithmatt
approved these changes
Mar 2, 2022
shahsank3t
approved these changes
Mar 2, 2022
|
Does jest get installed on CI ? Got this failure on a recent PR for 'yarn run build-test' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes :
Fix #3016
Type of change :
Checklist: