Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up System.out.println and bump up ingestion-core version #3072

Merged
merged 1 commit into from Mar 2, 2022

Conversation

mithmatt
Copy link
Collaborator

@mithmatt mithmatt commented Mar 2, 2022

Describe your changes :

I worked on this to remove System.out.println and bump up the python package version to make the CI pass...

Type of change :

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Frontend Preview (Screenshots) :

For frontend related change, please link screenshots of your changes preview! Optional for backend related changes.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my own.
  • I have tagged my reviewers below.
  • I have commented on my code, particularly in hard-to-understand areas.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • All new and existing tests passed.

Reviewers

Backend: @sureshms @harshach
Ingestion: @harshach @ayush-shah @pmbrull

@mithmatt mithmatt requested a review from pmbrull March 2, 2022 09:14
Copy link
Collaborator

@pmbrull pmbrull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks mate

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2022

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mithmatt
Copy link
Collaborator Author

mithmatt commented Mar 2, 2022

2022-03-02T09:29:10.6940201Z [INFO] --- frontend-maven-plugin:1.11.0:yarn (yarn run build-test) @ openmetadata-ui ---
2022-03-02T09:29:10.6970277Z [INFO] Running 'yarn run build-test' in /home/runner/work/OpenMetadata/OpenMetadata/openmetadata-ui/src/main/resources/ui
2022-03-02T09:29:10.9963630Z [INFO] yarn run v1.22.17
2022-03-02T09:29:11.0505470Z [INFO] $ yarn run test
2022-03-02T09:29:11.3806056Z [INFO] $ jest --passWithNoTests
2022-03-02T09:29:11.3940459Z [INFO] /bin/sh: 1: jest: not found
2022-03-02T09:29:11.4047714Z [INFO] error Command failed with exit code 127.
2022-03-02T09:29:11.4049479Z [INFO] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2022-03-02T09:29:11.4318520Z [INFO] error Command failed with exit code 127.
2022-03-02T09:29:11.4319082Z [INFO] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
2022-03-02T09:29:11.4509518Z [INFO] ------------------------------------------------------------------------
2022-03-02T09:29:11.4510046Z [INFO] Reactor Summary for catalog 0.9.0-SNAPSHOT:
2022-03-02T09:29:11.4510409Z [INFO] 
2022-03-02T09:29:11.4510672Z [INFO] catalog ............................................ SUCCESS [ 14.380 s]
2022-03-02T09:29:11.4511042Z [INFO] common ............................................. SUCCESS [ 16.488 s]
2022-03-02T09:29:11.4511752Z [INFO] catalog-rest-service ............................... SUCCESS [12:52 min]
2022-03-02T09:29:11.4512219Z [INFO] openmetadata-ui .................................... FAILURE [  4.859 s]
2022-03-02T09:29:11.4514380Z [INFO] Catalog Distribution ............................... SKIPPED
2022-03-02T09:29:11.4515422Z [INFO] ------------------------------------------------------------------------
2022-03-02T09:29:11.4515714Z [INFO] BUILD FAILURE
2022-03-02T09:29:11.4516147Z [INFO] ------------------------------------------------------------------------
2022-03-02T09:29:11.4516496Z [INFO] Total time:  13:31 min
2022-03-02T09:29:11.4516822Z [INFO] Finished at: 2022-03-02T09:29:11Z
2022-03-02T09:29:11.4517211Z [INFO] ------------------------------------------------------------------------
2022-03-02T09:29:11.4518134Z [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.11.0:yarn (yarn run build-test) on project openmetadata-ui: Failed to run task: 'yarn run build-test' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 127 (Exit value: 127) -> [Help 1]
2022-03-02T09:29:11.4518740Z [ERROR] 

Failure on UI code.. need to investigate separately. Merging this since this does not touch UI module

@mithmatt mithmatt merged commit 6c4bb1f into open-metadata:main Mar 2, 2022
@mithmatt mithmatt deleted the cleanup branch March 2, 2022 09:35
@sureshms
Copy link
Contributor

sureshms commented Mar 3, 2022

@mithmatt, I must have beaten you to removing System.out.printlns ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants