feat: support torch>=1.11 #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix open-mmlab#900. Support PyTorch version >= 1.11. Referring to pytorch/pytorch#66765 and https://github.com/pytorch/pytorch/wiki/TH-to-ATen-porting-guide.
|
Thanks, that's useful! Actually we have noticed this error before, have you tried to remove "include THC xxx" ? |
|
I'm using torch==1.12.0+cu116. After I removed in the modified 10 files, I could still successfully re-build OpenPCDet. Yet I'm not sure of the behavior for torch<=1.10. |
|
Yes, I have tried it before and it should also work for torch<=1.10. |
|
Hi @yihuajack , Can you help to remove these lines to support higher version PyTorch? So that I can merge your PR to the master. |
|
Removed |
OrangeSodahub
approved these changes
Aug 13, 2022
OrangeSodahub
approved these changes
Aug 13, 2022
sshaoshuai
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #900.
Support PyTorch version >= 1.11. Referring to pytorch/pytorch#66765 and https://github.com/pytorch/pytorch/wiki/TH-to-ATen-porting-guide.