Modify codes about version info #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamerlin
changed the title
__version____version__
dreamerlin
changed the title
__version____version__ and check mmcv version
innerlee
reviewed
Sep 17, 2020
dreamerlin
changed the title
__version__ and check mmcv version
Codecov Report
@@ Coverage Diff @@
## master #189 +/- ##
==========================================
- Coverage 85.87% 85.81% -0.06%
==========================================
Files 77 78 +1
Lines 4849 4871 +22
Branches 765 768 +3
==========================================
+ Hits 4164 4180 +16
- Misses 559 564 +5
- Partials 126 127 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
innerlee
reviewed
Sep 17, 2020
innerlee
reviewed
Sep 17, 2020
innerlee
reviewed
Sep 17, 2020
|
CU-4dnmw1 |
|
Task linked: CU-4dnmw1 MMAction2 |
|
Task linked: CU-4dnmxx MMAction2 |
innerlee
reviewed
Sep 18, 2020
| NUM_HASHES = 7 | ||
|
|
||
|
|
||
| def get_short_git_hash(num_hashes=7): |
There was a problem hiding this comment.
can this function be moved to mmcv?
There was a problem hiding this comment.
let's do it in a separate pr
innerlee
approved these changes
Sep 18, 2020
innerlee
reviewed
Sep 18, 2020
| short_version = __version__ | ||
|
|
||
|
|
||
| def parse_version_info(version_str): |
There was a problem hiding this comment.
this should also go to mmcv
innerlee
approved these changes
Sep 18, 2020
innerlee
reviewed
Sep 18, 2020
|
|
||
| import mmaction | ||
|
|
||
| NUM_HASHES = 7 |
There was a problem hiding this comment.
this is not needed any more
innerlee
reviewed
Sep 18, 2020
|
|
||
| def collect_env(): | ||
| env_info = collect_basic_env() | ||
| env_info['MMAction2'] = mmaction.__version__ | ||
| env_info['MMAction2'] = ( | ||
| mmaction.__version__ + '+' + get_short_git_hash(NUM_HASHES)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies codes related with some version information.
__version__.mmcvversion.