Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add init_eval to evaluation hook #216

Merged
merged 9 commits into from
Oct 21, 2020

Conversation

dreamerlin
Copy link
Collaborator

@dreamerlin dreamerlin commented Sep 26, 2020

  1. Add start argument in xxEvalHook to indicate the start time for evaluation
  2. Add prefix Epoch to indicate the current EvalHook is based on epochs

@codecov
Copy link

codecov bot commented Sep 26, 2020

Codecov Report

Merging #216 into master will increase coverage by 0.56%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #216      +/-   ##
==========================================
+ Coverage   84.40%   84.97%   +0.56%     
==========================================
  Files          87       87              
  Lines        5880     5910      +30     
  Branches      959      969      +10     
==========================================
+ Hits         4963     5022      +59     
+ Misses        744      705      -39     
- Partials      173      183      +10     
Flag Coverage Δ
#unittests 84.97% <84.21%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/apis/train.py 19.04% <50.00%> (ø)
mmaction/core/evaluation/eval_hooks.py 57.02% <85.71%> (+39.44%) ⬆️
mmaction/core/evaluation/__init__.py 100.00% <100.00%> (ø)
mmaction/datasets/pipelines/augmentations.py 95.00% <0.00%> (+0.71%) ⬆️
mmaction/core/evaluation/accuracy.py 89.85% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 794b2d0...df4c628. Read the comment docs.

@dreamerlin dreamerlin marked this pull request as ready for review October 10, 2020 13:23
@dreamerlin
Copy link
Collaborator Author

Ping @innerlee

@dreamerlin
Copy link
Collaborator Author

It is OK now @innerlee

@innerlee
Copy link
Contributor

for the renaming, have you searched through docs as well?

@dreamerlin
Copy link
Collaborator Author

dreamerlin commented Oct 21, 2020

for the renaming, have you searched through docs as well?

Oops, now it has been updated

@innerlee
Copy link
Contributor

hope this rename does not cause trouble

@innerlee innerlee merged commit 3a89dd3 into open-mmlab:master Oct 21, 2020
@innerlee innerlee deleted the eval_init branch October 21, 2020 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants