Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant code #310

Merged
merged 9 commits into from
Nov 10, 2020
Merged

Conversation

kennymckormick
Copy link
Member

No description provided.

@innerlee
Copy link
Contributor

innerlee commented Nov 3, 2020

Since you are at it, I guess the merge_configs has been implemented in mmcv?

@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #310 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   82.35%   82.29%   -0.06%     
==========================================
  Files          95       95              
  Lines        6777     6777              
  Branches     1099     1099              
==========================================
- Hits         5581     5577       -4     
- Misses        987      990       +3     
- Partials      209      210       +1     
Flag Coverage Δ
unittests 82.29% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/augmentations.py 94.45% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693f182...6ff2f73. Read the comment docs.

@kennymckormick
Copy link
Member Author

@tangh Hi, tang, seems the code is added by you in PR #198 . It is used in any circumstances during testing?

@kennymckormick
Copy link
Member Author

Since you are at it, I guess the merge_configs has been implemented in mmcv?

Yes, we can replace it.

@tangh
Copy link
Contributor

tangh commented Nov 3, 2020

@tangh Hi, tang, seems the code is added by you in PR #198 . It is used in any circumstances during testing?

Hi, these codes are added to avoid an error when someone running test script but have never run the training script. #198 (comment)

@kennymckormick
Copy link
Member Author

@tangh Hi, tang, seems the code is added by you in PR #198 . It is used in any circumstances during testing?

Hi, these codes are added to avoid an error when someone running test script but have never run the training script. #198 (comment)

Got it. I think it would be good to check if the output path exists (if not, mkdir), rather than mkdir work_dir

@innerlee innerlee merged commit 8b6ccd3 into open-mmlab:master Nov 10, 2020
@kennymckormick kennymckormick deleted the remove_redundant branch November 16, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants