Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NonLocal module in TSM and I3D #41

Merged
merged 6 commits into from
Jul 23, 2020
Merged

Conversation

dreamerlin
Copy link
Collaborator

No description provided.

@dreamerlin dreamerlin added the WIP work in progress label Jul 20, 2020
@codecov
Copy link

codecov bot commented Jul 20, 2020

Codecov Report

Merging #41 into master will increase coverage by 0.08%.
The diff coverage is 92.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   84.87%   84.95%   +0.08%     
==========================================
  Files          73       73              
  Lines        3827     3874      +47     
  Branches      618      627       +9     
==========================================
+ Hits         3248     3291      +43     
- Misses        480      482       +2     
- Partials       99      101       +2     
Flag Coverage Δ
#unittests 84.95% <92.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/models/backbones/resnet3d.py 89.69% <76.47%> (-0.89%) ⬇️
mmaction/models/backbones/resnet3d_slowfast.py 87.97% <100.00%> (+0.07%) ⬆️
mmaction/models/backbones/resnet_tsm.py 95.08% <100.00%> (+1.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d85364d...0c8d562. Read the comment docs.

@dreamerlin dreamerlin removed the WIP work in progress label Jul 23, 2020
@innerlee
Copy link
Contributor

will the trained models be added to modelzoo?

@innerlee innerlee merged commit 54e9b33 into open-mmlab:master Jul 23, 2020
@dreamerlin
Copy link
Collaborator Author

will the trained models be added to modelzoo?

Yes, the trained models will be added to the modelzoo when all the settings are ready.

@dreamerlin dreamerlin deleted the non_local branch July 26, 2020 13:49
@hellock hellock mentioned this pull request Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants