Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Simplify EditLogProcessor and corresponding unit test #1694

Merged

Conversation

LeoXing1996
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

MMEngine support _get_dataloader_size in open-mmlab/mmengine#972. Therefore we can simplify the logic of EditLogProcessor.

Modification

Overwrite _get_dataloader_size and remove duplicate codes with MMEngine.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@LeoXing1996 LeoXing1996 self-assigned this Mar 13, 2023
@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (a175a41) 88.14% compared to head (77a51be) 88.16%.

❗ Current head 77a51be differs from pull request most recent head 60f5f30. Consider uploading reports for the commit 60f5f30 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x    #1694      +/-   ##
===========================================
+ Coverage    88.14%   88.16%   +0.01%     
===========================================
  Files          399      399              
  Lines        26414    26348      -66     
  Branches      4124     4108      -16     
===========================================
- Hits         23282    23229      -53     
+ Misses        2245     2238       -7     
+ Partials       887      881       -6     
Flag Coverage Δ
unittests 88.16% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmedit/engine/runner/log_processor.py 100.00% <100.00%> (+17.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@zengyh1900 zengyh1900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LeoXing1996 LeoXing1996 merged commit c7bf402 into open-mmlab:dev-1.x Mar 13, 2023
@LeoXing1996 LeoXing1996 deleted the leoxing/update-log-processor branch March 13, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants