Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Revise the interface of upfirdn2d function #1195

Merged
merged 2 commits into from
Jul 20, 2021

Conversation

nbei
Copy link
Contributor

@nbei nbei commented Jul 12, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The StyleGAN2-ADA method needs a more general interface for the upfirdn2d function.

Modification

Just modify the interface of the upfirdn2d function to support more data types.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
No.

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #1195 (004085b) into master (96c4b70) will decrease coverage by 0.03%.
The diff coverage is 37.93%.

❗ Current head 004085b differs from pull request most recent head ad2ab24. Consider uploading reports for the commit ad2ab24 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1195      +/-   ##
==========================================
- Coverage   67.97%   67.94%   -0.04%     
==========================================
  Files         159      160       +1     
  Lines       10434    10454      +20     
  Branches     1899     1905       +6     
==========================================
+ Hits         7093     7103      +10     
- Misses       2970     2978       +8     
- Partials      371      373       +2     
Flag Coverage Δ
unittests 67.94% <37.93%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/cnn/utils/weight_init.py 91.34% <ø> (ø)
mmcv/runner/hooks/evaluation.py 86.70% <ø> (ø)
mmcv/runner/iter_based_runner.py 60.00% <0.00%> (+2.14%) ⬆️
mmcv/ops/upfirdn2d.py 14.58% <7.69%> (-0.72%) ⬇️
mmcv/utils/trace.py 54.54% <54.54%> (ø)
mmcv/image/photometric.py 99.27% <100.00%> (+<0.01%) ⬆️
mmcv/ops/cc_attention.py 38.70% <100.00%> (+1.00%) ⬆️
mmcv/utils/__init__.py 88.88% <100.00%> (+0.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96c4b70...ad2ab24. Read the comment docs.

@nbei nbei requested review from zhouzaida and ZwwWayne July 13, 2021 05:26
mmcv/ops/upfirdn2d.py Outdated Show resolved Hide resolved
mmcv/ops/upfirdn2d.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhouzaida zhouzaida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZwwWayne ZwwWayne merged commit faf6c6c into open-mmlab:master Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants