Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Fix the version of sphinx #1301

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

zhouzaida
Copy link
Collaborator

@zhouzaida zhouzaida commented Aug 25, 2021

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

As recommended by readthedocs, we should fix the version of sphinx.

Modification

Fix the version of sphinx

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #1301 (e47f07d) into master (7540cf7) will not change coverage.
The diff coverage is n/a.

❗ Current head e47f07d differs from pull request most recent head 053a574. Consider uploading reports for the commit 053a574 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1301   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         161      161           
  Lines       10742    10742           
  Branches     1972     1972           
=======================================
  Hits         7334     7334           
  Misses       3023     3023           
  Partials      385      385           
Flag Coverage Δ
unittests 68.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7540cf7...053a574. Read the comment docs.

@zhouzaida zhouzaida mentioned this pull request Aug 26, 2021
16 tasks
@ZwwWayne ZwwWayne merged commit 14f55e6 into open-mmlab:master Aug 27, 2021
@zhouzaida zhouzaida deleted the fix-sphinx-version branch August 27, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants