Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image.md: fix inconsistent API #19

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Conversation

kuonangzhe
Copy link
Contributor

Update old crop_img to imcrop, pad_img to impad

Update old crop_img and pad_img to imcrop and impad
Update image.md: fix inconsistent API
@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   41.11%   41.11%           
=======================================
  Files          67       67           
  Lines        2486     2486           
=======================================
  Hits         1022     1022           
  Misses       1464     1464

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da39212...7d35b4d. Read the comment docs.

@hellock
Copy link
Member

hellock commented Oct 13, 2018

Thanks for revising the typo in the documentation.

@hellock hellock merged commit e093bb1 into open-mmlab:master Oct 13, 2018
@kuonangzhe
Copy link
Contributor Author

Yep! My pleasure~

haofengac pushed a commit to haofengac/mmcv that referenced this pull request Nov 30, 2019
Update old crop_img and pad_img to imcrop and impad
pablodecm pushed a commit to pablodecm/mmcv that referenced this pull request Jul 20, 2020
@OpenMMLab-Assistant001
Copy link

Hi @kuonangzhe

First of all, we want to express our gratitude for your significant PR in the mmcv project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/raweFPmdzG

If you have WeChat,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)

Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants