Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileio related interfaces should keep bc #2539

Merged
merged 5 commits into from
Jan 17, 2023

Conversation

zhouzaida
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

PR (#2468) directly removed the file_client_args parameter and it causes bc issue. This PR fixes this issue.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 66.70% // Head: 66.28% // Decreases project coverage by -0.41% ⚠️

Coverage data is based on head (cc75b71) compared to base (32cc2f7).
Patch coverage: 48.46% of modified lines in pull request are covered.

❗ Current head cc75b71 differs from pull request most recent head a4cc3b0. Consider uploading reports for the commit a4cc3b0 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2539      +/-   ##
==========================================
- Coverage   66.70%   66.28%   -0.42%     
==========================================
  Files         120      121       +1     
  Lines        7817     7963     +146     
  Branches     1072     1098      +26     
==========================================
+ Hits         5214     5278      +64     
- Misses       2436     2506      +70     
- Partials      167      179      +12     
Flag Coverage Δ
unittests 66.28% <48.46%> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/focal_loss.py 25.00% <0.00%> (ø)
mmcv/ops/masked_conv.py 36.84% <0.00%> (-6.91%) ⬇️
mmcv/ops/modulated_deform_conv.py 65.18% <11.42%> (-15.30%) ⬇️
mmcv/ops/deform_conv.py 66.66% <20.00%> (-5.19%) ⬇️
mmcv/transforms/loading.py 83.17% <47.05%> (-16.83%) ⬇️
mmcv/ops/bezier_align.py 74.46% <74.46%> (ø)
mmcv/image/io.py 88.80% <100.00%> (+1.10%) ⬆️
mmcv/ops/__init__.py 100.00% <100.00%> (ø)
mmcv/transforms/processing.py 94.72% <100.00%> (ø)
mmcv/utils/__init__.py 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@HAOCHENYE HAOCHENYE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhouzaida zhouzaida merged commit 009cfe6 into open-mmlab:2.x Jan 17, 2023
@zhouzaida zhouzaida deleted the fileio-should-avoid-bc-issue branch January 17, 2023 05:10
tyomj pushed a commit to tyomj/mmcv that referenced this pull request May 8, 2023
* fileio related interfaces should keep bc

* fix format

* update unit tests of transforms

* update format

* lazily infer client until calling get function of fileio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants