New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] Remove file_client_args and apply new interface of fileio #662
[Refactor] Remove file_client_args and apply new interface of fileio #662
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev-1.x #662 +/- ##
===========================================
- Coverage 81.84% 80.59% -1.26%
===========================================
Files 120 141 +21
Lines 4176 5127 +951
Branches 586 687 +101
===========================================
+ Hits 3418 4132 +714
- Misses 645 855 +210
- Partials 113 140 +27
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
c721559
to
9020179
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As inline comments
Co-authored-by: Songyang Zhang <tonysy@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Use the new interface of fileio from MMEngine which requires mmengine>=0.2.0.
Refer to open-mmlab/mmcv#2468, open-mmlab/mmcv#2539
mmcv<2.0.0rc4
: need to set thefile_client_args
to indicate the backend, if thefile_client_args
isNone
, the default option will bedisk
backend.mmcv>=2.0.0rc4
: The function in fileio from MMEngine will automatically deal with different backends according to the prefix ofdata_root
, if parameterbackend_args
isNone
Modification
Update related configs, docs and ut
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: