Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove file_client_args and apply new interface of fileio #662

Merged
merged 5 commits into from Mar 14, 2023

Conversation

fangyixiao18
Copy link
Collaborator

@fangyixiao18 fangyixiao18 commented Jan 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Use the new interface of fileio from MMEngine which requires mmengine>=0.2.0.
Refer to open-mmlab/mmcv#2468, open-mmlab/mmcv#2539

mmcv<2.0.0rc4: need to set the file_client_args to indicate the backend, if the file_client_args is None, the default option will be disk backend.
mmcv>=2.0.0rc4 : The function in fileio from MMEngine will automatically deal with different backends according to the prefix of data_root, if parameter backend_args is None

Modification

Update related configs, docs and ut

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

docs/en/user_guides/1_config.md Outdated Show resolved Hide resolved
docs/en/user_guides/1_config.md Outdated Show resolved Hide resolved
docs/en/user_guides/1_config.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Patch coverage: 80.17% and project coverage change: -1.26 ⚠️

Comparison is base (a1f1dad) 81.84% compared to head (2f8a4e9) 80.59%.

❗ Current head 2f8a4e9 differs from pull request most recent head 90f2d36. Consider uploading reports for the commit 90f2d36 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-1.x     #662      +/-   ##
===========================================
- Coverage    81.84%   80.59%   -1.26%     
===========================================
  Files          120      141      +21     
  Lines         4176     5127     +951     
  Branches       586      687     +101     
===========================================
+ Hits          3418     4132     +714     
- Misses         645      855     +210     
- Partials       113      140      +27     
Flag Coverage Δ
unittests 80.59% <80.17%> (-1.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmselfsup/datasets/transforms/__init__.py 100.00% <ø> (ø)
mmselfsup/datasets/transforms/wrappers.py 100.00% <ø> (ø)
mmselfsup/engine/hooks/deepcluster_hook.py 38.88% <0.00%> (-0.55%) ⬇️
mmselfsup/engine/optimizers/lars.py 16.12% <ø> (ø)
mmselfsup/models/algorithms/odc.py 31.70% <ø> (ø)
mmselfsup/models/backbones/mae_vit.py 100.00% <ø> (ø)
mmselfsup/models/backbones/simmim_swin.py 86.95% <ø> (ø)
mmselfsup/models/heads/latent_heads.py 100.00% <ø> (ø)
mmselfsup/models/losses/swav_loss.py 83.01% <ø> (ø)
mmselfsup/models/backbones/mixmim_backbone.py 23.07% <23.07%> (ø)
... and 41 more

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As inline comments

docs/en/user_guides/1_config.md Outdated Show resolved Hide resolved
fangyixiao18 and others added 2 commits March 13, 2023 19:58
Co-authored-by: Songyang Zhang <tonysy@users.noreply.github.com>
Copy link
Collaborator

@tonysy tonysy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fangyixiao18 fangyixiao18 merged commit 824d62e into open-mmlab:dev-1.x Mar 14, 2023
8 of 9 checks passed
@fangyixiao18 fangyixiao18 deleted the remove-file-client branch April 6, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants