Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Support tvm 1.x #1531

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support tvm for 1.x #1216

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028
Copy link
Collaborator

@grimoire '.github/workflows/backend-tvm.yml' is missed

@grimoire
Copy link
Member Author

@grimoire '.github/workflows/backend-tvm.yml' is missed

@RunningLeon and I found that installing the dependency of tvm takes a long time. I decide to remove this workflow until I find a better solution(maybe a image with all dependency)

@lvhan028
Copy link
Collaborator

@grimoire '.github/workflows/backend-tvm.yml' is missed

@RunningLeon and I found that installing the dependency of tvm takes a long time. I decide to remove this workflow until I find a better solution(maybe a image with all dependency)

Can we make a prebuild tvm?

@grimoire
Copy link
Member Author

grimoire commented Dec 20, 2022

Can we make a prebuild tvm?

Errrr, this workflow is used to test the install script.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028
Copy link
Collaborator

Can we make a prebuild tvm?

Errrr, this workflow is used to test the install script.

Maybe we should use prebuilt tvm in the install script

@grimoire
Copy link
Member Author

Maybe we should use prebuilt tvm in the install script

Require further discuss.

@lvhan028 lvhan028 merged commit 0e65606 into open-mmlab:dev-1.x Dec 21, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* support tvm 1.x

* fix tvm sdk export
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants