Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace '.jpg' instead of 'jpg' to guarantee replacing file ending #11340

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

R-Fehler
Copy link
Contributor

@R-Fehler R-Fehler commented Jan 3, 2024

The Mapillary Vistas Dataset validation split contains random strings as filenames, one of which has 'jpg' as part of the random filename.

this results in a file not found error during validation when training with mapillary vistas dataset as a panoptic dataset

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

The Mapillary Vistas Dataset validation split contains random strings as filenames, one of which has 'jpg' as part of the random filename.

this results in a file not found error during validation when training with mapillary vistas dataset as a panoptic dataset

Modification

replace '.jpg' instead of 'jpg' with '.png'

BC-breaking (Optional)

no braking changes.

Use cases (Optional)

bug fix for widespread panoptic dataset: Mapillary Vistas Dataset.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMPreTrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

The Mapillary Vistas Dataset validation split contains random strings as filenames, one of which has 'jpg' as part of the random filename. 

this results in a file not found error during validation when training with mapillary vistas dataset as a panoptic dataset
@CLAassistant
Copy link

CLAassistant commented Jan 3, 2024

CLA assistant check
All committers have signed the CLA.

@hhaAndroid hhaAndroid changed the base branch from main to dev-3.x January 4, 2024 02:24
@hhaAndroid hhaAndroid merged commit 10ae0b3 into open-mmlab:dev-3.x Jan 4, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants