Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix (dpool): directly return empty if rois's length is 0 #2099

Merged
merged 5 commits into from
Feb 17, 2020
Merged

fix (dpool): directly return empty if rois's length is 0 #2099

merged 5 commits into from
Feb 17, 2020

Conversation

ZwwWayne
Copy link
Collaborator

Fix #2072

@hellock hellock removed the request for review from yhcao6 February 15, 2020 12:30
hellock
hellock reviewed Feb 17, 2020
View reviewed changes
tests/test_dpool.py Outdated
ModulatedDeformRoIPoolingPack)


def test_dpool_empty_cpu():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU inference for DCN is currently not supported, thus this may be unnecessary.

tests/test_dpool.py Outdated
def test_dpool_empty_cpu():
"""
CommandLine:
xdoctest -m tests/test_dpool.py test_dpool_empty_cpu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to use xdoctest to perform unit tests. It is mainly used to test the cases in docstrings.

tests/test_dpool.py Outdated
assert data.shape[0] == rois.shape[0]


def test_dpool_empty_gpu():
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-empty inputs may also be tested, which is unavailable on travis but available locally.

@hellock hellock merged commit c0ac99e into open-mmlab:master Feb 17, 2020
mattdawkins added a commit to VIAME/mmdetection that referenced this pull request Feb 26, 2020
@mattdawkins
Merge remote-tracking branch 'jon/dev/fix_fpn2' into viame/master
6ba17cd 
* jon/dev/fix_fpn2: (33 commits)
  Fix FPN upscale
  fix analyze log (open-mmlab#2150)
  Fix a documentation error in GETTING_STARTED.md (open-mmlab#2149)
  add optimizer registry (open-mmlab#2139)
  Update version to 1.1 (open-mmlab#2144)
  Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135)
  reset worker_seed (open-mmlab#2111)
  Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128)
  Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583)
  fixed test package (open-mmlab#2127)
  add an argument format-only to handle the json formating (open-mmlab#2114)
  fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116)
  fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099)
  fix workflow problem (open-mmlab#2103)
  Uint8 fix (open-mmlab#2105)
  Fix device bug (open-mmlab#2098)
  fix test ddp initialize (open-mmlab#2100)
  set FORCE_CUDA (open-mmlab#2097)
  Speed up sampler (open-mmlab#2094)
  Use official DDP to implement MMDDP (open-mmlab#2090)
  ...
mattdawkins added a commit to VIAME/mmdetection that referenced this pull request Mar 13, 2020
@mattdawkins
Merge tag 'v1.1.0' into HEAD
04edba8 
* tag 'v1.1.0': (29 commits)
  Update version to 1.1 (open-mmlab#2144)
  Fix IOU assigners when ignore_of_thr > 0 and no pred boxes (open-mmlab#2135)
  reset worker_seed (open-mmlab#2111)
  Fix issue with list of metrics in CustomDataset.evaluate (open-mmlab#2128)
  Code Release: CARAFE: Content-Aware ReAssembly of FEatures (ICCV 2019) (open-mmlab#1583)
  fixed test package (open-mmlab#2127)
  add an argument format-only to handle the json formating (open-mmlab#2114)
  fix (get_cls_results): use np.empty for empty bbox rather than np.arrary (open-mmlab#2116)
  fix (dpool): directly return empty if rois's length is 0 (open-mmlab#2099)
  fix workflow problem (open-mmlab#2103)
  Uint8 fix (open-mmlab#2105)
  Fix device bug (open-mmlab#2098)
  fix test ddp initialize (open-mmlab#2100)
  set FORCE_CUDA (open-mmlab#2097)
  Speed up sampler (open-mmlab#2094)
  Use official DDP to implement MMDDP (open-mmlab#2090)
  log meta (open-mmlab#2086)
  fix pad_val not used in class Pad when pad to a fixed size (open-mmlab#2093)
  remove cython docs (open-mmlab#2091)
  remove new_tensor (open-mmlab#2092)
  ...
ioir123ju pushed a commit to ioir123ju/mmdetection that referenced this pull request Mar 30, 2020
@ZwwWayne @ioir123ju
fix (dpool): directly return empty if rois's length is 0 (open-mmlab#…
c2707aa 
…2099)

* fix (dpool): directly return empty if rois's length is 0

* fix (dpool): also skip empty when no_trans=True

* reformat (test/test_dpool.py): reformat to pass flake8

* fix (test_dpool): skip gpu test when GPU is not avaliable

* rm (test_dpool.py): rm test_dpool since it is not very necessary in CI
mike112223 pushed a commit to mike112223/mmdetection that referenced this pull request Aug 25, 2020
@ZwwWayne
fix (dpool): directly return empty if rois's length is 0 (open-mmlab#…
15e671c 
…2099)

* fix (dpool): directly return empty if rois's length is 0

* fix (dpool): also skip empty when no_trans=True

* reformat (test/test_dpool.py): reformat to pass flake8

* fix (test_dpool): skip gpu test when GPU is not avaliable

* rm (test_dpool.py): rm test_dpool since it is not very necessary in CI
liuhuiCNN pushed a commit to liuhuiCNN/mmdetection that referenced this pull request May 21, 2021
@nemonameless
[Dygraph] add TTFNet (open-mmlab#2099)
93e2a44 
* ttfnet infer

* fix ttfnet deploy

* clean code

* add comment, fix config

* add comment, update modelzoo

* fix norm resize, update modelzoo
FANGAreNotGnu pushed a commit to FANGAreNotGnu/mmdetection that referenced this pull request Oct 23, 2023
@shchur
Make sure that time series splitter doesn't trim training series shor…
4a27971 
…ter than prediction_length + 1 (open-mmlab#2099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellock hellock hellock left review comments

@xvjiarui xvjiarui xvjiarui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rois.shape[0] == 0 in deformable pool
3 participants
@ZwwWayne @hellock @xvjiarui