Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Cutout #3521

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Implement Cutout #3521

merged 10 commits into from
Aug 12, 2020

Conversation

Chrisfsj2051
Copy link
Contributor

Please note that this is slightly different from the current version in mmdet-projects.
To be more specific, n_holes can be given as a tuple to specify the range and cutout_shape can be given as float value in order to be compatible with STAC.

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #3521 into master will increase coverage by 0.15%.
The diff coverage is 86.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3521      +/-   ##
==========================================
+ Coverage   58.88%   59.04%   +0.15%     
==========================================
  Files         205      205              
  Lines       13696    13731      +35     
  Branches     2310     2315       +5     
==========================================
+ Hits         8065     8107      +42     
+ Misses       5254     5248       -6     
+ Partials      377      376       -1     
Flag Coverage Δ
#unittests 59.04% <86.11%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/pipelines/transforms.py 73.93% <85.71%> (+0.63%) ⬆️
mmdet/datasets/pipelines/__init__.py 100.00% <100.00%> (ø)
mmdet/models/roi_heads/mask_heads/maskiou_head.py 97.87% <0.00%> (+5.31%) ⬆️
mmdet/models/roi_heads/mask_scoring_roi_head.py 100.00% <0.00%> (+18.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8d5f6c...d8e4c8b. Read the comment docs.

mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
mmdet/datasets/pipelines/transforms.py Outdated Show resolved Hide resolved
@hellock
Copy link
Member

hellock commented Aug 11, 2020

More unit tests can be added to increase the coverage.

@hellock
Copy link
Member

hellock commented Aug 11, 2020

Generally LGTM.

@Chrisfsj2051
Copy link
Contributor Author

Hi @hellock , the coverage has been improved. It seems like every statement (except for __repr__ method) have been covered.

@Chrisfsj2051
Copy link
Contributor Author

Is there anything wrong with the latest CI? It failed to install CUDA.

@hellock hellock merged commit 490d16a into open-mmlab:master Aug 12, 2020
@Chrisfsj2051 Chrisfsj2051 deleted the implement-cutout branch December 29, 2020 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants