Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support evaluation on multiple datasets through ConcatDataset #3522

Merged
merged 15 commits into from
Aug 22, 2020

Conversation

ZwwWayne
Copy link
Collaborator

@ZwwWayne ZwwWayne commented Aug 10, 2020

This PR supports to evaluate concatenated datasets.
Fix #3220, #2907, #3049

@ZwwWayne ZwwWayne added the WIP Working in progress label Aug 10, 2020
@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #3522 into master will increase coverage by 1.67%.
The diff coverage is 74.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3522      +/-   ##
==========================================
+ Coverage   59.04%   60.71%   +1.67%     
==========================================
  Files         205      205              
  Lines       13731    13770      +39     
  Branches     2315     2328      +13     
==========================================
+ Hits         8107     8360     +253     
+ Misses       5248     4990     -258     
- Partials      376      420      +44     
Flag Coverage Δ
#unittests 60.71% <74.46%> (+1.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/datasets/custom.py 51.42% <ø> (+15.71%) ⬆️
mmdet/models/roi_heads/bbox_heads/bbox_head.py 85.06% <0.00%> (ø)
mmdet/datasets/builder.py 59.72% <66.66%> (+28.37%) ⬆️
mmdet/models/detectors/base.py 51.14% <66.66%> (ø)
mmdet/datasets/dataset_wrappers.py 84.07% <78.37%> (+3.05%) ⬆️
mmdet/models/roi_heads/test_mixins.py 48.38% <0.00%> (-5.38%) ⬇️
mmdet/datasets/coco.py 45.39% <0.00%> (+33.78%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04c44d0...ecd4c01. Read the comment docs.

@ZwwWayne ZwwWayne changed the title Concat eval Support evaluation on multiple datasets through ConcatDataset Aug 11, 2020
mmdet/datasets/dataset_wrappers.py Outdated Show resolved Hide resolved
mmdet/datasets/dataset_wrappers.py Outdated Show resolved Hide resolved
mmdet/datasets/dataset_wrappers.py Outdated Show resolved Hide resolved
@ZwwWayne ZwwWayne removed the WIP Working in progress label Aug 12, 2020
@xvjiarui xvjiarui self-requested a review August 13, 2020 03:40
docs/tutorials/new_dataset.md Outdated Show resolved Hide resolved
docs/tutorials/new_dataset.md Outdated Show resolved Hide resolved
mmdet/datasets/dataset_wrappers.py Show resolved Hide resolved
docs/tutorials/new_dataset.md Outdated Show resolved Hide resolved
@hellock hellock merged commit 3e0a003 into open-mmlab:master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Evaluation over ConcatDataset
3 participants