-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New batch inference #3564
New batch inference #3564
Conversation
dict(type='RandomFlip'), | ||
dict(type='Normalize', **img_norm_cfg), | ||
dict(type='Pad', size_divisor=32), | ||
dict(type='DefaultFormatBundle'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add the corresponding description at the tutorial part since it seems that the default config must be modified.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the tutorial, please also add a note that batch inference is not recommended for unfixed image sizes since it would be even slower and hurt the performance.
Since this PR would change the interfaces when inference with batch size=1, it's better to make sure all models are compatible. is it convenient to run a benchmark test for all the pretrained models? |
Codecov Report
@@ Coverage Diff @@
## master #3564 +/- ##
==========================================
+ Coverage 61.01% 61.06% +0.05%
==========================================
Files 205 216 +11
Lines 13827 15315 +1488
Branches 2344 2607 +263
==========================================
+ Hits 8436 9352 +916
- Misses 4962 5498 +536
- Partials 429 465 +36
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I wonder if it is possible to summarize the tested scripts and configs to ensure compatibility. I think there are still several scripts left for compatibility check. To name a few, pytorch2onnx, webcam_demo etc. |
No description provided.