Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix atss no gt #3702

Merged
merged 2 commits into from
Sep 16, 2020
Merged

fix atss no gt #3702

merged 2 commits into from
Sep 16, 2020

Conversation

jshilong
Copy link
Collaborator

@jshilong jshilong commented Sep 7, 2020

Fixed two bug in the ATSS model, each occurred when a single image did not contain any gt boxe and the total batch did not contain any gt boxe respectively

@codecov
Copy link

codecov bot commented Sep 7, 2020

Codecov Report

Merging #3702 into master will decrease coverage by 0.33%.
The diff coverage is 49.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3702      +/-   ##
==========================================
- Coverage   61.12%   60.78%   -0.34%     
==========================================
  Files         216      217       +1     
  Lines       15315    15377      +62     
  Branches     2607     2629      +22     
==========================================
- Hits         9361     9347      -14     
- Misses       5489     5561      +72     
- Partials      465      469       +4     
Flag Coverage Δ
#unittests 60.78% <49.39%> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/apis/test.py 12.84% <0.00%> (-0.25%) ⬇️
mmdet/core/post_processing/merge_augs.py 80.35% <ø> (ø)
mmdet/datasets/lvis.py 13.24% <0.00%> (-1.15%) ⬇️
mmdet/models/detectors/base.py 50.76% <ø> (ø)
mmdet/models/dense_heads/atss_head.py 28.13% <25.00%> (+0.06%) ⬆️
mmdet/core/bbox/samplers/ohem_sampler.py 83.78% <50.00%> (-2.33%) ⬇️
mmdet/datasets/coco.py 45.63% <50.00%> (+0.24%) ⬆️
mmdet/models/backbones/res2net.py 82.67% <52.00%> (-7.62%) ⬇️
mmdet/core/anchor/anchor_generator.py 77.53% <100.00%> (ø)
mmdet/datasets/__init__.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4e2155...3384230. Read the comment docs.

@hellock
Copy link
Member

hellock commented Sep 12, 2020

ping @jshilong

@ZwwWayne ZwwWayne merged commit 6883c0f into open-mmlab:master Sep 16, 2020
@shinya7y shinya7y mentioned this pull request Apr 15, 2021
@jshilong jshilong deleted the atss_fix branch June 1, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants