Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Use mmcv.utils.collect_env to avoid duplicate codes #3779

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

hellock
Copy link
Member

@hellock hellock commented Sep 16, 2020

No description provided.

@hellock hellock requested a review from yhcao6 September 16, 2020 04:25
@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #3779 into master will increase coverage by 0.19%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3779      +/-   ##
==========================================
+ Coverage   60.93%   61.13%   +0.19%     
==========================================
  Files         217      217              
  Lines       15374    15336      -38     
  Branches     2628     2624       -4     
==========================================
+ Hits         9368     9375       +7     
+ Misses       5537     5491      -46     
- Partials      469      470       +1     
Flag Coverage Δ
#unittests 61.13% <66.66%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/utils/collect_env.py 40.00% <66.66%> (+17.08%) ⬆️
mmdet/models/detectors/cornernet.py 94.87% <0.00%> (-5.13%) ⬇️
mmdet/models/dense_heads/corner_head.py 74.31% <0.00%> (-1.92%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 97.87% <0.00%> (+5.31%) ⬆️
mmdet/models/roi_heads/mask_scoring_roi_head.py 91.07% <0.00%> (+32.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11b1ef8...8ca7483. Read the comment docs.

@hellock hellock merged commit 927d71a into open-mmlab:master Sep 17, 2020
@hellock hellock deleted the collect-env branch April 10, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants