Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sabl validating bug #3849

Merged
merged 1 commit into from
Sep 28, 2020
Merged

fix sabl validating bug #3849

merged 1 commit into from
Sep 28, 2020

Conversation

yuzhj
Copy link
Contributor

@yuzhj yuzhj commented Sep 28, 2020

@yuzhj yuzhj mentioned this pull request Sep 28, 2020
Closed
@codecov
Copy link

codecov bot commented Sep 28, 2020 •
edited

Codecov Report

Merging #3849 into master will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3849      +/-   ##
==========================================
- Coverage   62.48%   62.34%   -0.14%     
==========================================
  Files         219      219              
  Lines       16256    16258       +2     
  Branches     2753     2754       +1     
==========================================
- Hits        10157    10136      -21     
- Misses       5603     5627      +24     
+ Partials      496      495       -1
Flag Coverage Δ
#unittests 62.34% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdet/models/roi_heads/test_mixins.py 60.86% <100.00%> (+0.69%) ⬆️
mmdet/models/roi_heads/mask_scoring_roi_head.py 58.92% <0.00%> (-32.15%) ⬇️
mmdet/models/roi_heads/mask_heads/maskiou_head.py 92.47% <0.00%> (-5.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d460a53...3e0273a. Read the comment docs.

@hellock hellock requested a review from yhcao6 September 28, 2020 05:14
@hellock hellock merged commit c851164 into open-mmlab:master Sep 28, 2020
mattdawkins added a commit to VIAME/mmdetection that referenced this pull request Dec 3, 2020
@mattdawkins
Merge tag 'v2.5.0' into viame/master
2dbcca5 
* tag 'v2.5.0': (102 commits)
  Bump to v2.5.0 (open-mmlab#3879)
  [Fix]: fix mask rcnn training stuck problem when there is no positive rois (open-mmlab#3713)
  Add missing notes in data customization (open-mmlab#3906)
  support to use pytorch 1.6 in docker (open-mmlab#3905)
  [enhance]: Improve documentation of modules and dataset customization (open-mmlab#3821)
  fix cv2 import error of ligGL.so.1 (open-mmlab#3891)
  fix the API change bug of PAA (open-mmlab#3883)
  Fix typo in bbox_flip (open-mmlab#3886)
  [Enhance]: Convert mask to bool before using it as img's index for robustness and speedup (open-mmlab#3870)
  [Docs] Remove duplicate content in docs/config.md (open-mmlab#3875)
  [Docs] Fix typo in docs/tutorials/new_dataset.md (open-mmlab#3876)
  Support TTA of ATSS, FCOS, YOLOv3 (open-mmlab#3844)
  Fix nonzero in NMS for PyTorch 1.6.0 (open-mmlab#3867)
  [Refactor] refactor get_subset_by_classes in dataloader for training with empty-GT images (open-mmlab#3695)
  fix rpn transforming bug in two stage networks (open-mmlab#3754)
  Clean background_labels in the dense heads (open-mmlab#3221)
  improve the function of simple_test_bboxes (open-mmlab#3853)
  Add doc of modify loss (open-mmlab#3777)
  fix sabl validating bug (open-mmlab#3849)
  YOLACT (open-mmlab#3456)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhcao6 yhcao6 yhcao6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yuzhj @yhcao6 @hellock